From: Pavel Begunkov <[email protected]>
To: Kanchan Joshi <[email protected]>,
[email protected], [email protected], [email protected], [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected]
Subject: Re: [RFC PATCH 0/4] Asynchronous passthrough ioctl
Date: Wed, 27 Jan 2021 15:42:46 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 27/01/2021 15:00, Kanchan Joshi wrote:
> This RFC patchset adds asynchronous ioctl capability for NVMe devices.
> Purpose of RFC is to get the feedback and optimize the path.
>
> At the uppermost io-uring layer, a new opcode IORING_OP_IOCTL_PT is
> presented to user-space applications. Like regular-ioctl, it takes
> ioctl opcode and an optional argument (ioctl-specific input/output
> parameter). Unlike regular-ioctl, it is made to skip the block-layer
> and reach directly to the underlying driver (nvme in the case of this
> patchset). This path between io-uring and nvme is via a newly
> introduced block-device operation "async_ioctl". This operation
> expects io-uring to supply a callback function which can be used to
> report completion at later stage.
>
> For a regular ioctl, NVMe driver submits the command to the device and
> the submitter (task) is made to wait until completion arrives. For
> async-ioctl, completion is decoupled from submission. Submitter goes
> back to its business without waiting for nvme-completion. When
> nvme-completion arrives, it informs io-uring via the registered
> completion-handler. But some ioctls may require updating certain
> ioctl-specific fields which can be accessed only in context of the
> submitter task. For that reason, NVMe driver uses task-work infra for
> that ioctl-specific update. Since task-work is not exported, it cannot
> be referenced when nvme is compiled as a module. Therefore, one of the
> patch exports task-work API.
>
> Here goes example of usage (pseudo-code).
> Actual nvme-cli source, modified to issue all ioctls via this opcode
> is present at-
> https://github.com/joshkan/nvme-cli/commit/a008a733f24ab5593e7874cfbc69ee04e88068c5
see https://git.kernel.dk/cgit/linux-block/log/?h=io_uring-fops
Looks like good time to bring that branch/discussion back
>
> With regular ioctl-
> int nvme_submit_passthru(int fd, unsigned long ioctl_cmd,
> struct nvme_passthru_cmd *cmd)
> {
> return ioctl(fd, ioctl_cmd, cmd);
> }
>
> With uring passthru ioctl-
> int nvme_submit_passthru(int fd, unsigned long ioctl_cmd,
> struct nvme_passthru_cmd *cmd)
> {
> return uring_ioctl(fd, ioctl_cmd, cmd);
> }
> int uring_ioctl(int fd, unsinged long cmd, u64 arg)
> {
> sqe = io_uring_get_sqe(ring);
>
> /* prepare sqe */
> sqe->fd = fd;
> sqe->opcode = IORING_OP_IOCTL_PT;
> sqe->ioctl_cmd = cmd;
> sqe->ioctl_arg = arg;
>
> /* submit sqe */
> io_uring_submit(ring);
>
> /* reap completion and obtain result */
> io_uring_wait_cqe(ring, &cqe);
> printf("ioctl result =%d\n", cqe->res)
> }
>
> Kanchan Joshi (4):
> block: introduce async ioctl operation
> kernel: export task_work_add
> nvme: add async ioctl support
> io_uring: add async passthrough ioctl support
>
> drivers/nvme/host/core.c | 347 +++++++++++++++++++++++++++-------
> fs/io_uring.c | 77 ++++++++
> include/linux/blkdev.h | 12 ++
> include/uapi/linux/io_uring.h | 7 +-
> kernel/task_work.c | 2 +-
> 5 files changed, 376 insertions(+), 69 deletions(-)
>
--
Pavel Begunkov
next prev parent reply other threads:[~2021-01-27 15:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210127150134epcas5p251fc1de3ff3581dd4c68b3fbe0b9dd91@epcas5p2.samsung.com>
2021-01-27 15:00 ` [RFC PATCH 0/4] Asynchronous passthrough ioctl Kanchan Joshi
[not found] ` <CGME20210127150140epcas5p32832cc0c0db953db199eb9dd326f2d4c@epcas5p3.samsung.com>
2021-01-27 15:00 ` [RFC PATCH 1/4] block: introduce async ioctl operation Kanchan Joshi
[not found] ` <CGME20210127150144epcas5p29ccb35d7e7170aba7947b5ee16fd2db0@epcas5p2.samsung.com>
2021-01-27 15:00 ` [RFC PATCH 2/4] kernel: export task_work_add Kanchan Joshi
[not found] ` <CGME20210127150149epcas5p4fa8edd47712f28ccdd9bac5139fc6e61@epcas5p4.samsung.com>
2021-01-27 15:00 ` [RFC PATCH 3/4] nvme: add async ioctl support Kanchan Joshi
[not found] ` <CGME20210127150156epcas5p26cdf368e4ff6bffb132fa1c7f9430653@epcas5p2.samsung.com>
2021-01-27 15:00 ` [RFC PATCH 4/4] io_uring: add async passthrough " Kanchan Joshi
2021-01-27 15:42 ` Pavel Begunkov [this message]
2021-01-27 15:53 ` [RFC PATCH 0/4] Asynchronous passthrough ioctl Pavel Begunkov
2021-01-28 12:04 ` Kanchan Joshi
2021-01-28 14:38 ` Jens Axboe
2021-01-28 17:13 ` Kanchan Joshi
2021-01-28 17:24 ` Jens Axboe
2021-02-22 13:42 ` Kanchan Joshi
2021-02-22 14:33 ` Jens Axboe
2021-02-23 4:41 ` Kanchan Joshi
2021-01-28 14:50 ` Jens Axboe
2021-01-28 17:25 ` Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox