From: Jens Axboe <axboe@kernel.dk>
To: Dylan Yudaken <dyudaken@gmail.com>,
io-uring@vger.kernel.org, asml.silence@gmail.com
Subject: Re: [PATCH] io_uring: remove unneeded io_send_zc accounting
Date: Sun, 15 Feb 2026 16:51:59 -0700 [thread overview]
Message-ID: <49f25745-fa99-44c4-b74b-c44a961e387b@kernel.dk> (raw)
In-Reply-To: <20260215231523.308665-1-dyudaken@gmail.com>
On 2/15/26 4:15 PM, Dylan Yudaken wrote:
> zc->len and zc->buf are not actually used once you get to the retry
> stage. The buffer remains in kmsg->msg.msg_iter, which is setup in
> io_send_setup.
> Note: it still seems needed in io_send due to io_send_select_buffer
> needing it (for the len parameter).
>
> Signed-off-by: Dylan Yudaken <dyudaken@gmail.com>
> ---
> Hi,
>
> I'm reasonably sure this is correct - but I think Pavel might want to
> double check that I did not miss anything. The tests seem to pass with no
> changes.
FWIW looks good to me, and we should probably move towards just
tracking state in iov_iter for the other paths too and get rid of
this. Wild handwaving, haven't actually looked at it, but it'd be
a nice cleanup.
--
Jens Axboe
next prev parent reply other threads:[~2026-02-15 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 23:15 [PATCH] io_uring: remove unneeded io_send_zc accounting Dylan Yudaken
2026-02-15 23:39 ` Pavel Begunkov
2026-02-16 11:43 ` Pavel Begunkov
2026-02-15 23:51 ` Jens Axboe [this message]
2026-02-16 15:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49f25745-fa99-44c4-b74b-c44a961e387b@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=dyudaken@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox