From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@meta.com>,
io-uring@vger.kernel.org, csander@purestorage.com
Cc: Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv6 2/6] Add support IORING_SETUP_SQE_MIXED
Date: Wed, 22 Oct 2025 11:35:19 -0600 [thread overview]
Message-ID: <4a6dfe74-0152-407b-987e-12befd319303@kernel.dk> (raw)
In-Reply-To: <20251022171924.2326863-3-kbusch@meta.com>
On 10/22/25 11:19 AM, Keith Busch wrote:
> +
> +/*
> + * Return a 128B sqe to fill. Applications must later call io_uring_submit()
> + * when it's ready to tell the kernel about it. The caller may call this
> + * function multiple times before calling io_uring_submit().
> + *
> + * Returns a vacant 128B sqe, or NULL if we're full. If the current tail is the
> + * last entry in the ring, this function will insert a nop + skip complete such
> + * that the 128b entry wraps back to the beginning of the queue for a
> + * contiguous big sq entry. It's up to the caller to use a 128b opcode in order
> + * for the kernel to know how to advance its sq head pointer.
> + */
> +IOURINGINLINE struct io_uring_sqe *io_uring_get_sqe128(struct io_uring *ring)
> + LIBURING_NOEXCEPT
> +{
> + struct io_uring_sq *sq = &ring->sq;
> + unsigned head = io_uring_load_sq_head(ring), tail = sq->sqe_tail;
> + struct io_uring_sqe *sqe;
> +
> + if (ring->flags & IORING_SETUP_SQE128)
> + return io_uring_get_sqe(ring);
> + if (!(ring->flags & IORING_SETUP_SQE_MIXED))
> + return NULL;
> +
> + if (((tail + 1) & sq->ring_mask) == 0) {
> + if ((tail + 2) - head >= sq->ring_entries)
> + return NULL;
> +
> + sqe = _io_uring_get_sqe(ring);
> + io_uring_prep_nop(sqe);
> + sqe->flags |= IOSQE_CQE_SKIP_SUCCESS;
> + tail = sq->sqe_tail;
> + } else if ((tail + 1) - head >= sq->ring_entries) {
> + return NULL;
> + }
> +
> + sqe = &sq->sqes[tail & sq->ring_mask];
> + sq->sqe_tail = tail + 2;
> + io_uring_initialize_sqe(sqe);
> + return sqe;
> +}
I did apply the patches, but can you add a man page addition for this
one?
--
Jens Axboe
next prev parent reply other threads:[~2025-10-22 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 17:19 [PATCHv6 0/6] liburing: support for mixed sqes Keith Busch
2025-10-22 17:19 ` [PATCHv6 1/6] liburing: provide uring_cmd prep function Keith Busch
2025-10-22 17:19 ` [PATCHv6 2/6] Add support IORING_SETUP_SQE_MIXED Keith Busch
2025-10-22 17:35 ` Jens Axboe [this message]
2025-10-22 17:19 ` [PATCHv6 3/6] test: add nop testing for IORING_SETUP_SQE_MIXED Keith Busch
2025-10-22 17:19 ` [PATCHv6 4/6] test: add mixed sqe test for uring commands Keith Busch
2025-10-22 17:19 ` [PATCHv6 5/6] test/fdinfo: flush sq prior to reading Keith Busch
2025-10-22 17:19 ` [PATCHv6 6/6] test/fdinfo: add mixed sqe option to fdinfo test Keith Busch
2025-10-22 17:40 ` [PATCHv6 0/6] liburing: support for mixed sqes Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a6dfe74-0152-407b-987e-12befd319303@kernel.dk \
--to=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox