From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6E8C433DF for ; Sat, 10 Oct 2020 23:12:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A438120760 for ; Sat, 10 Oct 2020 23:12:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="glDvi59x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389376AbgJJWzf (ORCPT ); Sat, 10 Oct 2020 18:55:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730273AbgJJSs2 (ORCPT ); Sat, 10 Oct 2020 14:48:28 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DD7AC05BD39 for ; Sat, 10 Oct 2020 11:48:27 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 13so13083527wmf.0 for ; Sat, 10 Oct 2020 11:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3rspjLQxKPHJzGlIl/ut6SgMbLbRfVbs/HZUSE6GqvE=; b=glDvi59xAEvBorOtupDu8h2CX2VKVeZ7uPHltrUyENFzh9st7WEBZwEocC2vHqWhjs /BPqYx0Ro/Qf8uRZ4pUC3UcBIMoFC7EDYEmQXiYOHD9cFfM9Rgp7krIA0LNuqHb2lBRE Cai+IGPbpLBbho7n6IuV3vlA/nHQu0BWuaAiCLeDp9tVcQ4KHneK3j+FL4r5Zsy7grz8 OK5idziahQC3ONXmSYSdInYFxFH+HNrzCCE+K+/6at5z+dLuH4UCM80kClDXVJXSM9lT mhS+GB+e3pIMbcXmmnjuDyhxaiFTIzRBdD5uEsp34hWhxs03STzcZbcy1fgxlOfJXlhc OFwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3rspjLQxKPHJzGlIl/ut6SgMbLbRfVbs/HZUSE6GqvE=; b=e0Fs7dNdbOoRENHP8Qu1Qk17xLMb+SxTNGWZrwuQbvjobyCpBXhldYkSLQiQDChrxJ LQI18n70qihAltJA31734r0zp9rxlkvH2rB4WbeSRJQS4xkMcADxg4SXmD4YkXG2Kv4W 5A+BBGf6cLp+65XvilB4QvdOKv7iXv3W9dKamFijYk62fRwY01Ihe+jgZpxxt4tgjM3C FJoHuytV31ZmNby9+iVuoNVaoINEmn1ITeIloAY4fuu8wL9LNgV2I306lSzv0h56R4uG 0azpyGvPDmDLr+HTYpTIcdLuTIdDxWFvi0UOFMhGvzZOijKFa2ov5iqK1/D3xn1xxuJJ U7cA== X-Gm-Message-State: AOAM530ZZxq8KwoPWUCmi/0qQqHOC9OBYU8Kfn23T3DmMZjGaNR9dJvO u1WFu7tyNZMmj4POl1AiMq0= X-Google-Smtp-Source: ABdhPJyCczvKpXIAvkYilTC5jnkhZZdmoVQvnP7s8Bsmejb/BL4vhhgm17Wfkw/nxnLV0HnoCeXIjg== X-Received: by 2002:a1c:60d5:: with SMTP id u204mr805255wmb.46.1602355705966; Sat, 10 Oct 2020 11:48:25 -0700 (PDT) Received: from [192.168.1.79] (host109-152-100-228.range109-152.btcentralplus.com. [109.152.100.228]) by smtp.gmail.com with ESMTPSA id z6sm11890971wrs.2.2020.10.10.11.48.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Oct 2020 11:48:25 -0700 (PDT) Subject: Re: [PATCH 01/12] io_uring: don't io_prep_async_work() linked reqs From: Pavel Begunkov To: Jens Axboe , io-uring@vger.kernel.org Cc: "Reported-by : Roman Gershman" References: <26fb33734fee5294f3d20b8be9cf52848056a630.1602350805.git.asml.silence@gmail.com> Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Message-ID: <4b92981a-5469-615f-02e6-6f3f75d7ff3f@gmail.com> Date: Sat, 10 Oct 2020 19:45:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <26fb33734fee5294f3d20b8be9cf52848056a630.1602350805.git.asml.silence@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 10/10/2020 18:34, Pavel Begunkov wrote: > There is no real reason left for preparing io-wq work context for linked > requests in advance, remove it as this might become a bottleneck in some > cases. > > Reported-by: Reported-by: Roman Gershman It looks like "Reported-by:" got duplicated. s/Reported-by: Reported-by:/Reported-by:/ > Signed-off-by: Pavel Begunkov > --- > fs/io_uring.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/io_uring.c b/fs/io_uring.c > index 09494ca1b990..272abe03a79e 100644 > --- a/fs/io_uring.c > +++ b/fs/io_uring.c > @@ -5672,9 +5672,6 @@ static int io_req_defer_prep(struct io_kiocb *req, > ret = io_prep_work_files(req); > if (unlikely(ret)) > return ret; > - > - io_prep_async_work(req); > - > return io_req_prep(req, sqe); > } > > -- Pavel Begunkov