public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	io-uring Mailing List <io-uring@vger.kernel.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
	Ammar Faizi <ammarfaizi2@gnuweeb.org>
Subject: Re: [PATCH liburing 1/3] Revert "test/io_uring_register: kill old memfd test"
Date: Tue, 15 Jul 2025 08:10:16 -0600	[thread overview]
Message-ID: <4bc75566-9cb5-42ec-a6b7-16e04062e0c6@kernel.dk> (raw)
In-Reply-To: <20250715050629.1513826-2-alviro.iskandar@gnuweeb.org>

On 7/14/25 11:06 PM, Alviro Iskandar Setiawan wrote:
> This reverts commit 732bf609b670631731765a585a68d14ed3fdc9b7.
> 
> Bring back `CONFIG_HAVE_MEMFD_CREATE` and the associated memfd test
> to resolve Android build failures caused by:
> 
>   93d3a7a70b4a ("examples/zcrx: udmabuf backed areas")
> 
> It added a call to `memfd_create()`, which is unavailable on some
> Android toolchains, leading to the following build error:
> 
> ```
>   zcrx.c:111:10: error: call to undeclared function 'memfd_create'; ISO C99 and \
>   later do not support implicit function declarations \
>   [-Wimplicit-function-declaration]
>     111 |         memfd = memfd_create("udmabuf-test", MFD_ALLOW_SEALING);
>         |                 ^
> ```
> 
> This reversion is a preparation step for a proper fix by ensuring
> `memfd_create()` usage is guarded and portable. Issue #620 was
> initially unclear, but we now suspect it stemmed from improper
> compiler/linker flag combinations.

Maybe just bring back the configure parts? The test, as mentioned in
that commit, is pretty useless.

-- 
Jens Axboe


  reply	other threads:[~2025-07-15 14:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15  5:06 [PATCH liburing 0/3] Bring back `CONFIG_HAVE_MEMFD_CREATE` to fix Android build error Alviro Iskandar Setiawan
2025-07-15  5:06 ` [PATCH liburing 1/3] Revert "test/io_uring_register: kill old memfd test" Alviro Iskandar Setiawan
2025-07-15 14:10   ` Jens Axboe [this message]
2025-07-16  0:03     ` Alviro Iskandar Setiawan
2025-07-15  5:06 ` [PATCH liburing 2/3] test: Move `memfd_create()` to helpers.c, make it accessible for all tests Alviro Iskandar Setiawan
2025-07-15  5:06 ` [PATCH liburing 3/3] examples: Add `memfd_create()` helper Alviro Iskandar Setiawan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bc75566-9cb5-42ec-a6b7-16e04062e0c6@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=alviro.iskandar@gnuweeb.org \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=gwml@vger.gnuweeb.org \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox