From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>,
Marcelo Diop-Gonzalez <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v4 0/1] io_uring: fix skipping of old timeout events
Date: Fri, 15 Jan 2021 18:48:58 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 15/01/2021 18:38, Jens Axboe wrote:
> On 1/15/21 11:31 AM, Marcelo Diop-Gonzalez wrote:
>> On Fri, Jan 15, 2021 at 10:02:12AM -0700, Jens Axboe wrote:
>>> On 1/15/21 9:54 AM, Marcelo Diop-Gonzalez wrote:
>>>> This patch tries to fix a problem with IORING_OP_TIMEOUT events
>>>> not being flushed if they should already have expired. The test below
>>>> hangs before this change (unless you run with $ ./a.out ~/somefile 1):
>>>
>>> Can you turn this into a test case for liburing? I'll apply the
>>> associated patch, thanks (and to Pavel for review as well).
>>
>> Yup, can do. I'll try to clean it up some first (especially so it
>> doesn't just hang when it fails :/)
>
> That'd of course be nice, but not a hard requirement. A lot of the
> regressions tests will crash a broken kernel, so...
Ha, they definitely will.
Marcelo, replacing reads with nop requests should trigger it as well,
it's probably easier and even more reliable as we always complete
them inline (if not linked or IOSQE_ASYNC).
--
Pavel Begunkov
next prev parent reply other threads:[~2021-01-15 18:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 16:54 [PATCH v4 0/1] io_uring: fix skipping of old timeout events Marcelo Diop-Gonzalez
2021-01-15 16:54 ` [PATCH v4 1/1] io_uring: flush timeouts that should already have expired Marcelo Diop-Gonzalez
2021-01-15 17:02 ` [PATCH v4 0/1] io_uring: fix skipping of old timeout events Jens Axboe
2021-01-15 18:31 ` Marcelo Diop-Gonzalez
2021-01-15 18:38 ` Jens Axboe
2021-01-15 18:48 ` Pavel Begunkov [this message]
2021-01-15 22:15 ` Marcelo Diop-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox