From: Pavel Begunkov <asml.silence@gmail.com>
To: io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH 1/1] io_uring/net: fix io_req_post_cqe abuse by send bundle
Date: Wed, 26 Mar 2025 22:29:54 +0000 [thread overview]
Message-ID: <4cddc5aa-a5c6-43f6-9816-7f975b1e1d51@gmail.com> (raw)
In-Reply-To: <3a6638b0f3567a00cfaabd80821fab3b60d49b36.1743027688.git.asml.silence@gmail.com>
On 3/26/25 22:21, Pavel Begunkov wrote:
> [ 114.987980][ T5313] WARNING: CPU: 6 PID: 5313 at io_uring/io_uring.c:872 io_req_post_cqe+0x12e/0x4f0
> [ 114.991597][ T5313] RIP: 0010:io_req_post_cqe+0x12e/0x4f0
> [ 115.001880][ T5313] Call Trace:
> [ 115.002222][ T5313] <TASK>
> [ 115.007813][ T5313] io_send+0x4fe/0x10f0
> [ 115.009317][ T5313] io_issue_sqe+0x1a6/0x1740
> [ 115.012094][ T5313] io_wq_submit_work+0x38b/0xed0
> [ 115.013223][ T5313] io_worker_handle_work+0x62a/0x1600
> [ 115.013876][ T5313] io_wq_worker+0x34f/0xdf0
>
> As the comment states, io_req_post_cqe() should only be used by
> multishot requests, i.e. REQ_F_APOLL_MULTISHOT, which bundled sends are
> not. Add a flag signifying whether a request wants to post multiple
> CQEs. Eventually REQ_F_APOLL_MULTISHOT should imply the new flag, but
> that's left out for simplicity.
Needs v2
--
Pavel Begunkov
prev parent reply other threads:[~2025-03-26 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 22:21 [PATCH 1/1] io_uring/net: fix io_req_post_cqe abuse by send bundle Pavel Begunkov
2025-03-26 22:29 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cddc5aa-a5c6-43f6-9816-7f975b1e1d51@gmail.com \
--to=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox