public inbox for [email protected]
 help / color / mirror / Atom feed
From: Xiaoguang Wang <[email protected]>
To: Jens Axboe <[email protected]>,
	Pavel Begunkov <[email protected]>,
	[email protected]
Cc: [email protected]
Subject: Re: [PATCH v6 1/2] io_uring: avoid whole io_wq_work copy for requests completed inline
Date: Wed, 10 Jun 2020 19:39:14 +0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

hi,

> On 6/9/20 10:44 AM, Pavel Begunkov wrote:
>> On 09/06/2020 11:25, Xiaoguang Wang wrote:
>>> If requests can be submitted and completed inline, we don't need to
>>> initialize whole io_wq_work in io_init_req(), which is an expensive
>>> operation, add a new 'REQ_F_WORK_INITIALIZED' to control whether
>>> io_wq_work is initialized.
>>
>> Basically it's "call io_req_init_async() before touching ->work" now.
>> This shouldn't be as easy to screw as was with ->func.
>>
>> The only thing left that I don't like _too_ much to stop complaining
>> is ->creds handling. But this one should be easy, see incremental diff
>> below (not tested). If custom creds are provided, it initialises
>> req->work in req_init() and sets work.creds. And then we can remove
>> req->creds.
>>
>> What do you think? Custom ->creds (aka personality) is a niche feature,
>> and the speedup is not so great to care.
> 
> Thanks for reviewing, I agree. Xiaoguang, care to fold in that change
> and then I think we're good to shove this in.
Yeah, I'll send new version soon.
Pavel, thanks for your great work, and really appreciate both of you and jens' patience.

Regards,
Xiaoguang Wang
> 

  reply	other threads:[~2020-06-10 11:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09  8:25 [PATCH v6 1/2] io_uring: avoid whole io_wq_work copy for requests completed inline Xiaoguang Wang
2020-06-09  8:25 ` [PATCH v6 2/2] io_uring: avoid unnecessary io_wq_work copy for fast poll feature Xiaoguang Wang
2020-06-09  8:32   ` Xiaoguang Wang
2020-06-09 16:44 ` [PATCH v6 1/2] io_uring: avoid whole io_wq_work copy for requests completed inline Pavel Begunkov
2020-06-10  1:40   ` Jens Axboe
2020-06-10 11:39     ` Xiaoguang Wang [this message]
2020-06-11 13:45       ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d5b9706-9abf-55c4-1f01-d87d536e5b45@linux.alibaba.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox