public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Stefan Roesch <[email protected]>
Cc: Facebook Kernel Team <[email protected]>,
	Jens Axboe <[email protected]>,
	Olivier Langlois <[email protected]>,
	Jakub Kicinski <[email protected]>,
	netdev Mailing List <[email protected]>,
	io-uring Mailing List <[email protected]>
Subject: Re: [PATCH v5 3/4] liburing: add example programs for napi busy poll
Date: Sat, 26 Nov 2022 04:34:33 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 11/22/22 2:14 AM, Stefan Roesch wrote:
> This adds two example programs to test the napi busy poll functionality.
> It consists of a client program and a server program. To get a napi id,
> the client and the server program need to be run on different hosts.
> 
> To test the napi busy poll timeout, the -t needs to be specified. A
> reasonable value for the busy poll timeout is 100. By specifying the
> busy poll timeout on the server and the client the best results are
> accomplished.
> 
> Signed-off-by: Stefan Roesch <[email protected]>

Also, please fix your indentation. You have random indentation all
over the places.

   Applying: liburing: add example programs for napi busy poll
   .git/rebase-apply/patch:258: space before tab in indent.
           	avgRTT += ctx->rtt[i];
   .git/rebase-apply/patch:322: trailing whitespace.
   	int flag;
   .git/rebase-apply/patch:346: space before tab in indent.
                   	opt.sq_poll = true;
   .git/rebase-apply/patch:382: space before tab in indent.
           	fprintf(stderr, "inet_pton error for %s\n", optarg);
   .git/rebase-apply/patch:391: space before tab in indent.
           	fprintf(stderr, "socket() failed: (%d) %s\n", errno, strerror(errno));
   warning: squelched 6 whitespace errors
   warning: 11 lines add whitespace errors.

-- 
Ammar Faizi


  parent reply	other threads:[~2022-11-25 21:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 19:14 [PATCH v5 0/4] liburing: add api for napi busy poll Stefan Roesch
2022-11-21 19:14 ` [PATCH v5 1/4] liburing: add api to set napi busy poll settings Stefan Roesch
2022-11-21 19:14 ` [PATCH v5 2/4] liburing: add documentation for new napi busy polling Stefan Roesch
2022-11-21 19:14 ` [PATCH v5 3/4] liburing: add example programs for napi busy poll Stefan Roesch
2022-11-25 21:31   ` Ammar Faizi
2022-11-25 21:34   ` Ammar Faizi [this message]
2022-11-21 19:14 ` [PATCH v5 4/4] liburing: update changelog with new feature Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox