Re: [PATCH v4 3/3] io_uring: Introduce getsockname io_uring cmd

[Jens Axboe <axboe@kernel.dk>]

On 11/25/25 2:18 PM, Gabriel Krisman Bertazi wrote:
> +static int io_uring_cmd_getsockname(struct socket *sock,
> +				    struct io_uring_cmd *cmd,
> +				    unsigned int issue_flags)
> +{
> +	const struct io_uring_sqe *sqe = cmd->sqe;
> +	struct sockaddr __user *uaddr;
> +	unsigned int peer;
> +	int __user *ulen;
> +
> +	if (sqe->ioprio || sqe->__pad1 || sqe->len || sqe->rw_flags)
> +		return -EINVAL;
> +
> +	uaddr = u64_to_user_ptr(READ_ONCE(sqe->addr));
> +	ulen = u64_to_user_ptr(sqe->addr3);

Missing READ_ONCE() for this one. But I can just amend that, pretty
trivial.

Outside of that, this looks good to me. Bigger question is how to stage
this, in terms of the two networking patches. Jakub?

-- 
Jens Axboe