From: Ammar Faizi <[email protected]>
To: Alviro Iskandar Setiawan <[email protected]>
Cc: Jens Axboe <[email protected]>, Dylan Yudaken <[email protected]>,
Facebook Kernel Team <[email protected]>,
Pavel Begunkov <[email protected]>,
io-uring Mailing List <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
Kanna Scarlet <[email protected]>,
Muhammad Rizki <[email protected]>
Subject: Re: [RESEND PATCH liburing v1 02/12] t/poll-link: Don't brute force the port number
Date: Fri, 2 Sep 2022 13:18:48 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOG64qNCEss+i-MQV4gJjZh4Eun1o0U1E2WcFrgeg1ifjUMo6Q@mail.gmail.com>
On 9/2/22 1:04 PM, Alviro Iskandar Setiawan wrote:
> On Fri, Sep 2, 2022 at 8:18 AM Ammar Faizi wrote:
>> static void signal_var(int *var)
>> {
>> pthread_mutex_lock(&mutex);
>> *var = 1;
>> @@ -80,45 +81,37 @@ void *recv_thread(void *arg)
>> ret = io_uring_queue_init(8, &ring, 0);
>> assert(ret == 0);
>>
>> int s0 = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
>> assert(s0 != -1);
>>
>> int32_t val = 1;
>> ret = setsockopt(s0, SOL_SOCKET, SO_REUSEPORT, &val, sizeof(val));
>> assert(ret != -1);
>> ret = setsockopt(s0, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val));
>> assert(ret != -1);
>>
>> - struct sockaddr_in addr;
>> + struct sockaddr_in addr = { };
>
> move this variable to the top plz, with that fixed:
>
> Reviewed-by: Alviro Iskandar Setiawan <[email protected]>
Will do that in v2 revision. Thanks!
--
Ammar Faizi
next prev parent reply other threads:[~2022-09-02 6:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 1:17 [RESEND PATCH liburing v1 00/12] Introducing t_bind_ephemeral_port() function Ammar Faizi
2022-09-02 1:17 ` [RESEND PATCH liburing v1 01/12] test/helpers: Add `t_bind_ephemeral_port()` function Ammar Faizi
2022-09-02 5:56 ` Alviro Iskandar Setiawan
2022-09-02 1:17 ` [RESEND PATCH liburing v1 02/12] t/poll-link: Don't brute force the port number Ammar Faizi
2022-09-02 6:04 ` Alviro Iskandar Setiawan
2022-09-02 6:18 ` Ammar Faizi [this message]
2022-09-02 1:17 ` [RESEND PATCH liburing v1 03/12] t/socket-rw: " Ammar Faizi
2022-09-02 6:07 ` Alviro Iskandar Setiawan
2022-09-02 1:17 ` [RESEND PATCH liburing v1 04/12] t/socket-rw-eagain: " Ammar Faizi
2022-09-02 6:08 ` Alviro Iskandar Setiawan
2022-09-02 1:17 ` [RESEND PATCH liburing v1 05/12] t/socket-rw-offset: " Ammar Faizi
2022-09-02 6:17 ` Alviro Iskandar Setiawan
2022-09-02 1:17 ` [RESEND PATCH liburing v1 06/12] t/files-exit-hang-poll: " Ammar Faizi
2022-09-02 6:20 ` Alviro Iskandar Setiawan
2022-09-02 1:17 ` [RESEND PATCH liburing v1 07/12] t/socket: Don't use a static " Ammar Faizi
2022-09-02 1:17 ` [RESEND PATCH liburing v1 08/12] t/connect: " Ammar Faizi
2022-09-02 1:17 ` [RESEND PATCH liburing v1 09/12] t/shutdown: " Ammar Faizi
2022-09-02 1:17 ` [RESEND PATCH liburing v1 10/12] t/recv-msgall: " Ammar Faizi
2022-09-02 1:17 ` [RESEND PATCH liburing v1 11/12] t/232c93d07b74: " Ammar Faizi
2022-09-02 1:17 ` [RESEND PATCH liburing v1 12/12] t/recv-msgall-stream: " Ammar Faizi
2022-09-02 6:35 ` [RESEND PATCH liburing v1 00/12] Introducing t_bind_ephemeral_port() function Alviro Iskandar Setiawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox