public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Hao Xu <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH 6/6] io_uring: add flag for allocating a fully sparse direct descriptor space
Date: Tue, 10 May 2022 06:27:48 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 5/9/22 10:44 PM, Hao Xu wrote:
>> @@ -11931,6 +11937,9 @@ static int __io_uring_register(struct io_ring_ctx *ctx, unsigned opcode,
>>           ret = io_sqe_buffers_unregister(ctx);
>>           break;
>>       case IORING_REGISTER_FILES:
>> +        ret = -EFAULT;
>> +        if (!arg)
>> +            break;
>>           ret = io_sqe_files_register(ctx, arg, nr_args, NULL);
>>           break;
>>       case IORING_UNREGISTER_FILES:
>> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
>> index b7f02a55032a..d09cf7c0d1fe 100644
>> --- a/include/uapi/linux/io_uring.h
>> +++ b/include/uapi/linux/io_uring.h
>> @@ -396,9 +396,15 @@ struct io_uring_files_update {
>>       __aligned_u64 /* __s32 * */ fds;
>>   };
>>   +/*
>> + * Register a fully sparse file sparse, rather than pass in an array of all
> 
>                                     ^space

Thanks, fixed.

>> + * -1 file descriptors.
>> + */
>> +#define IORING_RSRC_REGISTER_SPARSE    (1U << 0)
>> +
>>   struct io_uring_rsrc_register {
>>       __u32 nr;
>> -    __u32 resv;
>> +    __u32 flags;
>>       __u64 resv2;
>>       __aligned_u64 data;
>>       __aligned_u64 tags;
> 
> This looks promising, we may eliminate cqes for open/accept_direct reqs.
> 
> feel free to add,
> Reviewed-by: Hao Xu <[email protected]>

Added, thanks. Did you review the other ones too?

-- 
Jens Axboe


  reply	other threads:[~2022-05-10 12:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 15:50 [PATCHSET v2 0/6] Allow allocated direct descriptors Jens Axboe
2022-05-09 15:50 ` [PATCH 1/6] io_uring: track fixed files with a bitmap Jens Axboe
2022-05-09 15:50 ` [PATCH 2/6] io_uring: add basic fixed file allocator Jens Axboe
2022-05-09 15:50 ` [PATCH 3/6] io_uring: allow allocated fixed files for openat/openat2 Jens Axboe
2022-05-12  8:21   ` Hao Xu
2022-05-12 12:23     ` Jens Axboe
2022-05-13  5:28       ` Hao Xu
2022-05-13 12:25         ` Jens Axboe
2022-05-13 12:56           ` Jens Axboe
2022-05-13  4:38   ` Hao Xu
2022-05-13 12:28     ` Jens Axboe
2022-05-09 15:50 ` [PATCH 4/6] io_uring: allow allocated fixed files for accept Jens Axboe
2022-05-09 15:50 ` [PATCH 5/6] io_uring: bump max direct descriptor count to 1M Jens Axboe
2022-05-09 15:50 ` [PATCH 6/6] io_uring: add flag for allocating a fully sparse direct descriptor space Jens Axboe
2022-05-10  4:44   ` Hao Xu
2022-05-10 12:27     ` Jens Axboe [this message]
2022-05-13 10:56 ` [PATCHSET v2 0/6] Allow allocated direct descriptors Hao Xu
2022-06-09  8:57 ` Stefan Metzmacher
2022-06-10 11:06   ` Hao Xu
2022-06-10 11:28     ` Stefan Metzmacher
2022-06-10 13:04       ` Hao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox