public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Mina Almasry <[email protected]>
Cc: Jakub Kicinski <[email protected]>, David Wei <[email protected]>,
	[email protected], [email protected],
	Jens Axboe <[email protected]>, Paolo Abeni <[email protected]>,
	"David S. Miller" <[email protected]>,
	Eric Dumazet <[email protected]>,
	Jesper Dangaard Brouer <[email protected]>,
	David Ahern <[email protected]>,
	Stanislav Fomichev <[email protected]>,
	Joe Damato <[email protected]>,
	Pedro Tammela <[email protected]>
Subject: Re: [PATCH net-next v9 08/20] net: expose page_pool_{set,clear}_pp_info
Date: Mon, 6 Jan 2025 23:48:00 +0000	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHS8izOb59+Z4phe=nJNVOTjOy2HByuh4N-RBgJd5dvhLC9F0A@mail.gmail.com>

On 1/6/25 22:17, Mina Almasry wrote:
> On Thu, Jan 2, 2025 at 8:20 AM Pavel Begunkov <[email protected]> wrote:
>>
>> On 12/21/24 02:23, Jakub Kicinski wrote:
>>> On Sat, 21 Dec 2024 01:07:44 +0000 Pavel Begunkov wrote:
>>>>>> Memory providers need to set page pool to its net_iovs on allocation, so
>>>>>> expose page_pool_{set,clear}_pp_info to providers outside net/.
>>>>>
>>>>> I'd really rather not expose such low level functions in a header
>>>>> included by every single user of the page pool API.
>>>>
>>>> Are you fine if it's exposed in a new header file?
>>>
>>> I guess.
>>>
>>> I'm uncomfortable with the "outside net/" phrasing of the commit
>>> message. Nothing outside net should used this stuff. Next we'll have
>>> a four letter subsystem abusing it and claiming that it's in a header
>>> so it's a public.
>>
>> By net/ I purely meant the folder, even though it also dictates
>> the available API. io_uring is outside, having some glue API
>> between them is the only way I can think of, even if it looks
>> different from the current series.
>>
>> Since there are strong opinions would make sense to shove it into
>> a new file and name helpers more appropriately, like net_mp_*.
>>
> 
> I guess I'm a bit sorry here because I think I suggested this
> approach. I think the root of the issue is that the io_uring memory

No worries, that wasn't the reason at all. It got split to
support multiple pools per provider because of intricacies of
the queue api.

In v10 {set,clear}_pp* it's wrapped into helpers, which hide
even more networking bits.

-- 
Pavel Begunkov


  reply	other threads:[~2025-01-06 23:47 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18  0:37 [PATCH RESEND net-next v9 00/21] io_uring zero copy rx David Wei
2024-12-18  0:37 ` [PATCH net-next v9 01/20] net: page_pool: don't cast mp param to devmem David Wei
2024-12-20 22:04   ` Jakub Kicinski
2025-01-06 20:45   ` Mina Almasry
2024-12-18  0:37 ` [PATCH net-next v9 02/20] net: prefix devmem specific helpers David Wei
2024-12-20 22:05   ` Jakub Kicinski
2024-12-18  0:37 ` [PATCH net-next v9 03/20] net: generalise net_iov chunk owners David Wei
2024-12-20 22:14   ` Jakub Kicinski
2024-12-21  0:50     ` Pavel Begunkov
2024-12-21  2:17       ` Jakub Kicinski
2025-01-02 15:52         ` Pavel Begunkov
2025-01-06 21:05   ` Mina Almasry
2024-12-18  0:37 ` [PATCH net-next v9 04/20] net: page_pool: create hooks for custom page providers David Wei
2025-01-02 15:54   ` Pavel Begunkov
2024-12-18  0:37 ` [PATCH net-next v9 05/20] net: page_pool: add mp op for netlink reporting David Wei
2024-12-20 22:16   ` Jakub Kicinski
2025-01-06 23:21     ` David Wei
2025-01-06 21:24   ` Mina Almasry
2024-12-18  0:37 ` [PATCH net-next v9 06/20] net: page_pool: add a mp hook to unregister_netdevice* David Wei
2024-12-20 22:18   ` Jakub Kicinski
2025-01-06 21:44   ` Mina Almasry
2025-01-06 23:34     ` David Wei
2025-01-06 23:39     ` Pavel Begunkov
2024-12-18  0:37 ` [PATCH net-next v9 07/20] net: prepare for non devmem TCP memory providers David Wei
2024-12-20 22:18   ` Jakub Kicinski
2024-12-18  0:37 ` [PATCH net-next v9 08/20] net: expose page_pool_{set,clear}_pp_info David Wei
2024-12-20 22:31   ` Jakub Kicinski
2024-12-21  1:07     ` Pavel Begunkov
2024-12-21  2:23       ` Jakub Kicinski
2025-01-02 16:21         ` Pavel Begunkov
2025-01-06 22:17           ` Mina Almasry
2025-01-06 23:48             ` Pavel Begunkov [this message]
2024-12-18  0:37 ` [PATCH net-next v9 09/20] net: page_pool: introduce page_pool_mp_return_in_cache David Wei
2024-12-18  0:37 ` [PATCH net-next v9 10/20] io_uring/zcrx: add interface queue and refill queue David Wei
2024-12-18  0:37 ` [PATCH net-next v9 11/20] io_uring/zcrx: add io_zcrx_area David Wei
2025-01-06 22:46   ` Mina Almasry
2025-01-07  0:04     ` Pavel Begunkov
2024-12-18  0:37 ` [PATCH net-next v9 12/20] io_uring/zcrx: grab a net device David Wei
2024-12-18  0:37 ` [PATCH net-next v9 13/20] net: page pool: export page_pool_set_dma_addr_netmem() David Wei
2024-12-18  0:37 ` [PATCH net-next v9 14/20] io_uring/zcrx: dma-map area for the device David Wei
2024-12-20 22:38   ` Jakub Kicinski
2024-12-21  1:04     ` Pavel Begunkov
2024-12-18  0:37 ` [PATCH net-next v9 15/20] io_uring/zcrx: add io_recvzc request David Wei
2024-12-18  0:37 ` [PATCH net-next v9 16/20] io_uring/zcrx: set pp memory provider for an rx queue David Wei
2024-12-18  0:37 ` [PATCH net-next v9 17/20] io_uring/zcrx: throttle receive requests David Wei
2024-12-18  0:37 ` [PATCH net-next v9 18/20] io_uring/zcrx: add copy fallback David Wei
2024-12-18  0:37 ` [PATCH net-next v9 19/20] net: add documentation for io_uring zcrx David Wei
2024-12-18  0:37 ` [PATCH net-next v9 20/20] io_uring/zcrx: add selftest David Wei
2024-12-18 14:40 ` [PATCH RESEND net-next v9 00/21] io_uring zero copy rx Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox