From: Jens Axboe <axboe@kernel.dk>
To: Cinq Prairie <notprairie@gmail.com>
Cc: Stefan Roesch <shr@devkernel.io>,
Jakub Kicinski <kuba@kernel.org>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring/napi: drop the single NAPI busy poll special case
Date: Mon, 26 Oct 2026 20:32:54 -0600 [thread overview]
Message-ID: <51d9c80e-1bfc-43e5-a195-46b4b7612de1@kernel.dk> (raw)
In-Reply-To: <20261026231718.5092-1-notprairie@gmail.com>
On 10/26/26 5:17 PM, Cinq Prairie wrote:
> I'm thinking that with the re-entry in place io_uring can cond_resched()
> when the napi loop bailed on a need_resched() then resume, between laps
> it holds nothing from the list and is in sleepable context. That would
> mirror the socket path. Though it also impacts the multi-NAPI path,
> which never yielded so far, so I'd like your preference: include it in
> v2, or keep v2 to the single-NAPI fix and send the yield as a follow-up?
Let's keep v2 the single-NAPI fix, and then you can do a follow-up
on top of that.
> I'll also add numbers for the single-NAPI fast path when it is not cut
> short, before/after, so the cost is visible.
Sounds good, thanks!
--
Jens Axboe
prev parent reply other threads:[~2026-10-27 2:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 23:29 [PATCH] io_uring/napi: drop the single NAPI busy poll special case Cinq Prairie
2026-10-26 13:46 ` Jens Axboe
2026-10-26 23:17 ` Cinq Prairie
2026-10-27 2:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51d9c80e-1bfc-43e5-a195-46b4b7612de1@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=notprairie@gmail.com \
--cc=shr@devkernel.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox