public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: [email protected]
Cc: Jens Axboe <[email protected]>, [email protected]
Subject: [PATCH liburing v2 5/5] examples/send-zc: kill sock bufs configuration
Date: Sun,  5 Mar 2023 05:13:08 +0000	[thread overview]
Message-ID: <521e3524b08499700c927984fbf6a25b38ed2e40.1677993039.git.asml.silence@gmail.com> (raw)
In-Reply-To: <[email protected]>

Remove SO_RCVLOWAT / SO_RCVBUF, they are arbitrary and drastically
affect performance.

Signed-off-by: Pavel Begunkov <[email protected]>
---
 examples/send-zerocopy.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/examples/send-zerocopy.c b/examples/send-zerocopy.c
index 8e1242e..f400f38 100644
--- a/examples/send-zerocopy.c
+++ b/examples/send-zerocopy.c
@@ -237,8 +237,6 @@ static void do_setup_rx(int domain, int type, int protocol)
 	if (fd == -1)
 		t_error(1, errno, "socket r");
 
-	do_setsockopt(fd, SOL_SOCKET, SO_RCVBUF, 1 << 21);
-	do_setsockopt(fd, SOL_SOCKET, SO_RCVLOWAT, 1 << 16);
 	do_setsockopt(fd, SOL_SOCKET, SO_REUSEPORT, 1);
 
 	setup_sockaddr(cfg_family, str_addr, &addr);
@@ -328,8 +326,6 @@ static void do_tx(struct thread_data *td, int domain, int type, int protocol)
 	if (fd == -1)
 		t_error(1, errno, "socket t");
 
-	do_setsockopt(fd, SOL_SOCKET, SO_SNDBUF, 1 << 21);
-
 	if (connect(fd, (void *)&td->dst_addr, cfg_alen))
 		t_error(1, errno, "connect, idx %i", td->idx);
 
-- 
2.39.1


  parent reply	other threads:[~2023-03-05  5:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-05  5:13 [PATCH liburing v2 0/5] sendzc test improvements Pavel Begunkov
2023-03-05  5:13 ` [PATCH liburing v2 1/5] examples/send-zc: add defer taskrun support Pavel Begunkov
2023-03-05  5:13 ` [PATCH liburing v2 2/5] examples/send-zc: add affinity / CPU pinning Pavel Begunkov
2023-03-05  5:13 ` [PATCH liburing v2 3/5] examples/send-zc: add multithreading Pavel Begunkov
2023-03-05  5:13 ` [PATCH liburing v2 4/5] examples/send-zc: add the receive part Pavel Begunkov
2023-03-05  5:13 ` Pavel Begunkov [this message]
2023-03-05 14:35 ` [PATCH liburing v2 0/5] sendzc test improvements Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521e3524b08499700c927984fbf6a25b38ed2e40.1677993039.git.asml.silence@gmail.com \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox