Re: [PATCH v2] io_uring/io-wq: fix incorrect io_wq_for_each_worker() termination logic

[Jens Axboe <axboe@kernel.dk>]

On 1/5/26 11:07 AM, Gabriel Krisman Bertazi wrote:
> Jens Axboe <axboe@kernel.dk> writes:
> 
>> A previous commit added this helper, and had it terminate if false is
>> returned from the handler. However, that is completely opposite, it
>> should abort the loop if true is returned.
>>
>> Fix this up by having io_wq_for_each_worker() keep iterating as long
>> as false is returned, and only abort if true is returned.
> 
> The fix is good, but the API is just weird.
> 
> io_acct_for_each_worker returning true indicates an error that will
> abort the wq walk.  It is a non-issue, since all the two callers cannot
> fail and always return false for success :-)
> 
> Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>

Thanks for taking a look! Was going to post a followup just killing
the return value of io_wq_for_each_worker() to void as nobody uses
it. Only the cancelation side with its matching will use a true
return, most of iterations want to iterate all of them.

-- 
Jens Axboe