From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D0CC433FE for ; Fri, 18 Feb 2022 16:15:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234399AbiBRQPf (ORCPT ); Fri, 18 Feb 2022 11:15:35 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:36724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237491AbiBRQPd (ORCPT ); Fri, 18 Feb 2022 11:15:33 -0500 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11FAF2B2E3C for ; Fri, 18 Feb 2022 08:15:16 -0800 (PST) Received: by mail-io1-xd2b.google.com with SMTP id q8so8146502iod.2 for ; Fri, 18 Feb 2022 08:15:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=qWMpF7raOj8BVgLSwxE6N8xfeTMyRc3jlMQt3XZTb/Q=; b=cVDsvk13PER+8/C+glX1jr0iFEn+/YdKItnMY2h6ih54AETiXBhUZP/QdQapgrpssn sxZWcdpbYkCZpYi/BlgGznFK7NmSIcjrJs4PGMbFt4QFaEcpHZBlRwsdnrZcLaqHuWWx 6nCZrVgF7LoNLo16HORGYuXV2ZURrVWEugIKKz1ZiJa9/JmKSF6KMVtxWdipCodxmnCz Q0QqBgCEltJNpdI5aiegfQNysjPrrXvZ0ngyAKLf6+e1uQmXCdD/b+xDi6zxspquB8fB KXNU8fQnsRmrlki0OP+1EZfpiHY8z2LOGEXOUzuVhoB29xRArc/PAR+7hlR/squgIKw+ j/zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=qWMpF7raOj8BVgLSwxE6N8xfeTMyRc3jlMQt3XZTb/Q=; b=R3iNxEIKLPhdcAaexH1XZC1NihT6HZfW+ZZvQDheCyV+phyq9hM0K2+WURyJEM0O1Y 0RYOK2uPCk8vpySuznSb9YJfqb4b7lIGgrPl7jCthyihuDnJFRdq5o8ZM3ljRIgBSiiG nOQJTq+P/DkUOF/zfnoyjonQE12TpGjTub1wlR1rEc/xPYYSlq6SrXBjWZv2o3Ev+Ry1 W6pqKWsOoCXo68VCl0ZyAElrJnSUTkaZ9pWK3kn3JpBR+8twpdgIglgr2u74GtbvX4+H sNwFIBiaw5XU7tB2CkTfclhEZXrBpniMZpwQ8QwI2vZWeSBgOuJd0rPac3ssSGuzjRwB cTfQ== X-Gm-Message-State: AOAM531I2WetZQPn4RPXYBjYu/8Mx19L5allhmtlbtvVhVmXWe5MKIOK mKSHarsPVhlbKakfKrEchkexRw== X-Google-Smtp-Source: ABdhPJznRFMzQDAyGIgaJlH35YCnK/ivRBbFWmLPN+d/dPKxDRvdhLuORDY+Kcclwlg50DF9Kmmv3w== X-Received: by 2002:a05:6638:4189:b0:314:5435:76a1 with SMTP id az9-20020a056638418900b00314543576a1mr5631166jab.263.1645200915428; Fri, 18 Feb 2022 08:15:15 -0800 (PST) Received: from [192.168.1.172] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id k10sm3654846ilu.63.2022.02.18.08.15.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Feb 2022 08:15:14 -0800 (PST) Message-ID: <539953d3-bc83-0b6d-24b3-214f6cdaeb65@kernel.dk> Date: Fri, 18 Feb 2022 09:15:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v3 0/2] io-uring: Make statx api stable Content-Language: en-US To: Stefan Roesch , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@fb.com Cc: viro@zeniv.linux.org.uk References: <20220215180328.2320199-1-shr@fb.com> From: Jens Axboe In-Reply-To: <20220215180328.2320199-1-shr@fb.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/15/22 11:03 AM, Stefan Roesch wrote: > One of the key architectual tenets of io-uring is to keep the > parameters for io-uring stable. After the call has been submitted, > its value can be changed. Unfortunaltely this is not the case for > the current statx implementation. > > Patches: > Patch 1: fs: replace const char* parameter in vfs_statx and do_statx with > struct filename > Create filename object outside of do_statx and vfs_statx, so io-uring > can create the filename object during the prepare phase > > Patch 2: io-uring: Copy path name during prepare stage for statx > Create and store filename object during prepare phase > > > There is also a patch for the liburing libray to add a new test case. This > patch makes sure that the api is stable. > "liburing: add test for stable statx api" > > The patch has been tested with the liburing test suite and fstests. Al, are you happy with this version? -- Jens Axboe