From: Jens Axboe <[email protected]>
To: Linus Torvalds <[email protected]>
Cc: "[email protected]" <[email protected]>,
io-uring <[email protected]>
Subject: Re: [GIT PULL] io_uring fixes for 5.7-rc
Date: Fri, 17 Apr 2020 11:42:29 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHk-=wiWP0M=ZAim7VVuoR+5ri+Ug+KZDE-TZskma4HV91ACxA@mail.gmail.com>
On 4/17/20 11:26 AM, Linus Torvalds wrote:
> On Fri, Apr 17, 2020 at 8:16 AM Jens Axboe <[email protected]> wrote:
>>
>> - Work restore poll cancelation fix
>
> That whole apoll thing is disgusting.
>
> I cannot convince myself it is right. How do you convince yourself?
req->poll is used for pure poll requests, req->apoll is used for poll
that is armed on behalf of a non-poll request. So the paths are actually
pretty well defined, for both the submission side entry, and the
completion side which is through the wakeup handlers.
The handlers that deal with the "poll on behalf of another request" is
pretty short and limited. Anything that uses "poll on behalf of others"
is not going to be queued async, which is the overlap with io_wq_work
in the io_kiocb structure. The only part we have to be a bit careful
with there is for the assume contexts, like mm etc. One of the fixes
in this pull request deals with that.
--
Jens Axboe
next prev parent reply other threads:[~2020-04-17 17:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 15:16 [GIT PULL] io_uring fixes for 5.7-rc Jens Axboe
2020-04-17 17:26 ` Linus Torvalds
2020-04-17 17:27 ` Linus Torvalds
2020-04-17 17:42 ` Jens Axboe [this message]
2020-04-17 17:45 ` pr-tracker-bot
-- strict thread matches above, loose matches on Subject: below --
2020-05-22 17:12 Jens Axboe
2020-05-22 19:05 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox