From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2104269AE5 for ; Tue, 18 Feb 2025 13:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739887197; cv=none; b=fqzYb4LcaqnukM1Y56lFUIjlOpCvTgVhm0Bd3M7AOZ8MsfkS6LpFaraVKt4BNp0H6sAFfe2N75C9j49hv6qp6GzxYvVKLzFiMkC/xG39u/v9YOZjZfB2Bsb0e6Is5S5DvYeD72JQi25WZEnXD8MLYbR6/4RvFN2X/X0XJdFl7iI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739887197; c=relaxed/simple; bh=oLapzg2kmr8ra4GmoxtioxQBLEe8tuDRu4pDXkNj86s=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:Content-Type; b=kbPh5l7dd2LQSCUyFuJKfXK/3OWi72oZpDjIn9gUXiajLcYTYAJTGpQwGKS8WjB6uzYs4Zn0S/u3SkHVMn+hMJG23axTnJ0VuubomgSl368IvymbVLMWd4fb2qyB3lchA+46ospAbB7GqiiBa5Xy5CLqnFazZjZY940kC7yKty8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b=QUvHzR5o; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="QUvHzR5o" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id EEC9D3FE6E for ; Tue, 18 Feb 2025 13:59:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1739887187; bh=TFVkVW8mqzZvRa2FQ2uGvuEytv7Dg/puiNRGWYVs8Vg=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:Content-Type; b=QUvHzR5oTp70JOo2wgCJP9JMcxSACzzX2Bc70kevRR2UgepF6eD0/jBW5PgTi/Hcq gn8Ae8xSAKx/qRL8AwugpiUcpwMm1k7aFmqu0GtYnTFdCyo85e7dG2xM1v9rxfpB0s fFu72fDOdeTVFXWctYBeltZlhfnG2WldjLf6jOH6F0KwgUQEjmDCxo8WOIBOG9gBuw urAFs06U5V/ND7DuCIspj6m5OhrRhLGdYkgTE+IhLfAnY43yBfENq2rmL0OneRRxCo DIhEgfycs7hFsktlpFEKNZsggwoox0aduoXXi50R9hnsKjGP28X5aUnVdCY2gCJ9L/ pGvbM8PokgZXg== Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43933b8d9b1so29372125e9.3 for ; Tue, 18 Feb 2025 05:59:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739887187; x=1740491987; h=content-transfer-encoding:cc:to:subject:from:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TFVkVW8mqzZvRa2FQ2uGvuEytv7Dg/puiNRGWYVs8Vg=; b=gm1+cP99J9+DUKy5+LMiJI6iUnHL9ta6MlpSI4L8eVo0f5YCxWNQv9dTVSytQ9zr0T lcdV3IZW9rP7V+zRzye2iyfjMZCCRKzqA6SJXLMivsGiz3bQMsnXorJoROs3UoDiBGMt oFBUh4lLBbgpoRnQV/0Uc+3yJg6J9Zk0utR6xj/n9g+vnQbRW0xZ1Gj2FrD7nn9m290f XmCpSUtlxuOprtXSPCvVVd1GyrStHELcuFix52JoQM8jErX0n955BoIs68DAMC2pRdTX QbvdXDBrSy6MciQWsEqvm2FmsxdkshsR/pMUPqtHi2r+tWVV//oSKZyQmYhBgNwlJPA+ pYAg== X-Forwarded-Encrypted: i=1; AJvYcCVyuy6rfeCFMGD67U/XjKEOhYrKnOB7zBlw5AE5rErNZG6wLIQp+eLiRAWf7UC++PbkK/Nr9aKZDw==@vger.kernel.org X-Gm-Message-State: AOJu0YyU7zY89riJ/vhUdxxVV6IkU1KyRRPJ3ISUs1sAT+vvaSZHr8Vb L1MVEYfvdUjNhCk+2nQGWtjK3HQG2PQPwOcc8k93cQFLzdaNgCnJUDINzL+oBiZVNdEqpIe4JL8 Pi4Ihf4DdSQBrmLHOWukvTrFlumYqkqTgRk/ICpqDTe/zYh9z0gdX4sUCNiM71PrDYkwmnJ+X X-Gm-Gg: ASbGncv8BSQqQuvTmKqwLqnaL7RTvZy/HSSi9VxM81bVxJMD8uBocUJPVDmbSwc7mfu rcaEijYq+Z4p7uBS4TdLd0IoXe0sYTGC5aDFU2EqSusLAOClgKtQop29+YiYV2Dcs68bJFWNtS/ pbSrLEoa2/1qaBA66xvcte7Dab+l8r/Gn4GYRhCqx4s+UwgrfCWRT/1ugOA5950nNn+nLDh8ceK 0Q7AcpeCrr7s4oCdyElJKKBfEPt340VXcRJvX9+msxXcoMMIsv4ASOIfGYAFxff+29L1FI870Zm C0hwdC7SlnlqgvwQGzp5LZ2ZGDTtZJ42L6H1R45QKapc86FuENc= X-Received: by 2002:a05:600c:1c28:b0:439:42c6:f11f with SMTP id 5b1f17b1804b1-4396e6ab033mr122972795e9.4.1739887187456; Tue, 18 Feb 2025 05:59:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHkuueM4q9zjyh2zOdRzt+GIWkGfCPkA6ywuytmuiaFKbIi3h6FEUwjrGAeEowaXsN5ZS1O9Q== X-Received: by 2002:a05:600c:1c28:b0:439:42c6:f11f with SMTP id 5b1f17b1804b1-4396e6ab033mr122972595e9.4.1739887187111; Tue, 18 Feb 2025 05:59:47 -0800 (PST) Received: from [192.168.80.20] (51.169.30.93.rev.sfr.net. [93.30.169.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4395a1b8397sm182603185e9.36.2025.02.18.05.59.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2025 05:59:46 -0800 (PST) Message-ID: <54095d2f-daea-4e4a-9542-f6a2b7603672@canonical.com> Date: Tue, 18 Feb 2025 14:59:45 +0100 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Olivier Gayot Subject: [PATCH v2 0/1 RESEND] block: fix conversion of GPT partition name to 7-bit To: Davidlohr Bueso , Jens Axboe , Ming Lei , Pavel Begunkov , linux-efi@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org Cc: olivier.gayot@canonical.com, daniel.bungert@canonical.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Dear maintainers, This is a resend of a patch that I originally sent in May 2023. Resending with an updated list of recipients since the list has been updated. Original submission: https://lore.kernel.org/linux-efi/f19a6d8a-c85a-963e-412e-efaa7f520453@canonical.com/T/#t http://www.uwsg.indiana.edu/hypermail/linux/kernel/2305.2/08638.html -- While investigating a userspace issue, we noticed that the PARTNAME udev property for GPT partitions is not always valid ASCII / UTF-8. The value of the PARTNAME property for GPT partitions is initially set by the kernel using the utf16_le_to_7bit function. This function does a very basic conversion from UTF-16 to 7-bit ASCII by dropping the first byte of each UTF-16 character and replacing the remaining byte by "!" if it is not printable. Essentially, it means that characters outside the ASCII range get "converted" to other characters which are unrelated. Using this function for data that is presented in userspace feels questionable and using a proper conversion to UTF-8 would probably be preferable. However, the patch attached does not attempt to change this design. The patch attached actually addresses an implementation issue in the utf16_le_to_7bit function, which causes the output of the function to not always be valid 7-bit ASCII. Olivier Gayot (1): block: fix conversion of GPT partition name to 7-bit ASCII block/partitions/efi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, Olivier