[syzbot] WARNING: still has locks held in io_ring_submit_lock

[syzbot] WARNING: still has locks held in io_ring_submit_lock

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    1e1b28b936ae Add linux-next specific files for 20220513
git tree:       linux-next
console+strace: https://syzkaller.appspot.com/x/log.txt?x=10872211f00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=e4eb3c0c4b289571
dashboard link: https://syzkaller.appspot.com/bug?extid=987d7bb19195ae45208c
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1141bd21f00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=167ebdbef00000

The issue was bisected to:

commit 6da69b1da130e7d96766042750cd9f902e890eba
Author: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Date:   Mon Mar 28 03:24:31 2022 +0000

    net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=1652eb11f00000
final oops:     https://syzkaller.appspot.com/x/report.txt?x=1552eb11f00000
console output: https://syzkaller.appspot.com/x/log.txt?x=1152eb11f00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+987d7bb19195ae45208c@syzkaller.appspotmail.com
Fixes: 6da69b1da130 ("net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator")

====================================
WARNING: iou-wrk-3613/3623 still has locks held!
5.18.0-rc6-next-20220513-syzkaller #0 Not tainted
------------------------------------
1 lock held by iou-wrk-3613/3623:
 #0: ffff888140bfe0a8 (&ctx->uring_lock){+.+.}-{3:3}, at: io_ring_submit_lock+0x75/0xc0 fs/io_uring.c:1494

stack backtrace:
CPU: 0 PID: 3623 Comm: iou-wrk-3613 Not tainted 5.18.0-rc6-next-20220513-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
 try_to_freeze include/linux/freezer.h:66 [inline]
 get_signal+0x1424/0x2600 kernel/signal.c:2647
 io_wqe_worker+0x64b/0xdb0 fs/io-wq.c:663
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:297
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

Re: [syzbot] WARNING: still has locks held in io_ring_submit_lock

[Jens Axboe]

On 5/15/22 8:52 AM, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    1e1b28b936ae Add linux-next specific files for 20220513
> git tree:       linux-next
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=10872211f00000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=e4eb3c0c4b289571
> dashboard link: https://syzkaller.appspot.com/bug?extid=987d7bb19195ae45208c
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1141bd21f00000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=167ebdbef00000
> 
> The issue was bisected to:
> 
> commit 6da69b1da130e7d96766042750cd9f902e890eba
> Author: Xiaomeng Tong <xiam0nd.tong@gmail.com>
> Date:   Mon Mar 28 03:24:31 2022 +0000
> 
>     net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator

That looks totally unrelated...

#syz test: git://git.kernel.dk/linux-block.git for-next

-- 
Jens Axboe

Re: [syzbot] WARNING: still has locks held in io_ring_submit_lock

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING: still has locks held in io_ring_submit_lock

====================================
WARNING: iou-wrk-4175/4176 still has locks held!
5.18.0-rc6-syzkaller-00294-gdf8dc7004331 #0 Not tainted
------------------------------------
1 lock held by iou-wrk-4175/4176:
 #0: ffff888019d050a8 (&ctx->uring_lock){+.+.}-{3:3}, at: io_ring_submit_lock+0x75/0xc0 fs/io_uring.c:1500

stack backtrace:
CPU: 1 PID: 4176 Comm: iou-wrk-4175 Not tainted 5.18.0-rc6-syzkaller-00294-gdf8dc7004331 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
 try_to_freeze include/linux/freezer.h:66 [inline]
 get_signal+0x17bb/0x24c0 kernel/signal.c:2654
 io_wqe_worker+0x64b/0xdb0 fs/io-wq.c:663
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
 </TASK>


Tested on:

commit:         df8dc700 Merge branch 'for-5.19/block' into for-next
git tree:       git://git.kernel.dk/linux-block.git for-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1275d495f00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=7b4d7b33ae78f4c2
dashboard link: https://syzkaller.appspot.com/bug?extid=987d7bb19195ae45208c
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Note: no patches were applied.

Re: [syzbot] WARNING: still has locks held in io_ring_submit_lock

[Jens Axboe]

On 5/15/22 11:42 AM, syzbot wrote:
> Hello,
> 
> syzbot has tested the proposed patch but the reproducer is still triggering an issue:
> WARNING: still has locks held in io_ring_submit_lock

Gah, might help if I actually push out the change...

#syz test: git://git.kernel.dk/linux-block.git for-next

-- 
Jens Axboe

Re: [syzbot] WARNING: still has locks held in io_ring_submit_lock

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+987d7bb19195ae45208c@syzkaller.appspotmail.com

Tested on:

commit:         3782ad72 Merge branch 'for-5.19/io_uring' into for-next
git tree:       git://git.kernel.dk/linux-block.git for-next
kernel config:  https://syzkaller.appspot.com/x/.config?x=7b4d7b33ae78f4c2
dashboard link: https://syzkaller.appspot.com/bug?extid=987d7bb19195ae45208c
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Note: no patches were applied.
Note: testing is done by a robot and is best-effort only.