public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Cc: [email protected], [email protected],
	[email protected],
	Pavel Begunkov <[email protected]>
Subject: [RFC for-next 1/4] bio: safeguard REQ_ALLOC_CACHE bio put
Date: Tue, 18 Oct 2022 19:47:13 +0100	[thread overview]
Message-ID: <558d78313476c4e9c233902efa0092644c3d420a.1666114003.git.asml.silence@gmail.com> (raw)
In-Reply-To: <[email protected]>

bio_put() with REQ_ALLOC_CACHE assumes that it's executed not from
an irq context. Let's add a warning if the invariant is not respected,
especially since there is a couple of places removing REQ_POLLED by hand
without also clearing REQ_ALLOC_CACHE.

Signed-off-by: Pavel Begunkov <[email protected]>
---
 block/bio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/bio.c b/block/bio.c
index 7cb7d2ff139b..5b4594daa259 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -741,7 +741,7 @@ void bio_put(struct bio *bio)
 			return;
 	}
 
-	if (bio->bi_opf & REQ_ALLOC_CACHE) {
+	if ((bio->bi_opf & REQ_ALLOC_CACHE) && !WARN_ON_ONCE(in_interrupt())) {
 		struct bio_alloc_cache *cache;
 
 		bio_uninit(bio);
-- 
2.38.0


  reply	other threads:[~2022-10-18 18:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 18:47 [RFC for-next 0/4] enable pcpu bio caching for IRQ I/O Pavel Begunkov
2022-10-18 18:47 ` Pavel Begunkov [this message]
2022-10-18 18:47 ` [RFC for-next 2/4] bio: split pcpu cache part of bio_put into a helper Pavel Begunkov
2022-10-18 18:47 ` [RFC for-next 3/4] block/bio: add pcpu caching for non-polling bio_put Pavel Begunkov
2022-10-18 18:47 ` [RFC for-next 4/4] io_uring/rw: enable bio caches for IRQ rw Pavel Begunkov
2022-10-18 19:33 ` [RFC for-next 0/4] enable pcpu bio caching for IRQ I/O Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558d78313476c4e9c233902efa0092644c3d420a.1666114003.git.asml.silence@gmail.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox