From: Jens Axboe <[email protected]>
To: Ziyang Zhang <[email protected]>, [email protected]
Cc: [email protected], [email protected]
Subject: Re: [PATCH tools/io_uring] tools/io_uring: correctly set "ret" for sq_poll case
Date: Wed, 22 Feb 2023 20:46:04 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 2/21/23 12:37?AM, Ziyang Zhang wrote:
> For sq_poll case, "ret" is not initialized or cleared/set. In this way,
> output of this test program is incorrect and we can not even stop this
> program by pressing CTRL-C.
>
> Reset "ret" to zero in each submission/completion round, and assign
> "ret" to "this_reap".
Can you check if this issue also exists in the fio copy of this, which
is t/io_uring.c in:
git://git.kernel.dk/fio
The copy in the kernel is pretty outdated at this point, and should
probably get removed. But if the bug is in the above main version, then
we should fix it there and then ponder if we want to remove the one in
the kernel or just get it updated to match the upstream version.
--
Jens Axboe
next prev parent reply other threads:[~2023-02-23 3:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 7:37 [PATCH tools/io_uring] tools/io_uring: correctly set "ret" for sq_poll case Ziyang Zhang
2023-02-23 3:46 ` Jens Axboe [this message]
2023-02-24 2:25 ` Ziyang Zhang
2023-02-24 2:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox