public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Joseph Qi <[email protected]>, Jens Axboe <[email protected]>,
	[email protected]
Subject: Re: [PATCH 0/3] files cancellation cleanup
Date: Fri, 22 Jan 2021 21:49:36 +0000	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 22/01/2021 09:45, Joseph Qi wrote:
> Seems this series can also resolve a possible deadlock case I'm looking
> into.

It removes dead code, I believe your issue is solved by
("io_uring: get rid of intermediate IORING_OP_CLOSE stage")
https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.12/io_uring&id=7be8ba3b656cb4e0158b2c859b949f34a96aa94f

Did you try this series in particular, or tested for-5.12/io_uring
and see that the issue is gone there?

> CPU0:
> ...
> io_kill_linked_timeout  // &ctx->completion_lock
> io_commit_cqring
> __io_queue_deferred
> __io_queue_async_work
> io_wq_enqueue
> io_wqe_enqueue  // &wqe->lock
> 
> CPU1:
> ...
> __io_uring_files_cancel
> io_wq_cancel_cb
> io_wqe_cancel_pending_work  // &wqe->lock
> io_cancel_task_cb  // &ctx->completion_lock
> 
> Thanks,
> Joseph
> 
> On 1/20/21 10:32 AM, Pavel Begunkov wrote:
>> Carefully remove leftovers from removing cancellations by files
>>
>> Pavel Begunkov (3):
>>   io_uring: remove cancel_files and inflight tracking
>>   io_uring: cleanup iowq cancellation files matching
>>   io_uring: don't pass files for cancellation
>>
>>  fs/io_uring.c | 168 ++++++++++----------------------------------------
>>  1 file changed, 32 insertions(+), 136 deletions(-)
>>

-- 
Pavel Begunkov

  reply	other threads:[~2021-01-22 21:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  2:32 [PATCH 0/3] files cancellation cleanup Pavel Begunkov
2021-01-20  2:32 ` [PATCH 1/3] io_uring: remove cancel_files and inflight tracking Pavel Begunkov
2021-01-20  2:32 ` [PATCH 2/3] io_uring: cleanup iowq cancellation files matching Pavel Begunkov
2021-01-20  2:32 ` [PATCH 3/3] io_uring: don't pass files for cancellation Pavel Begunkov
2021-01-20  3:13 ` [PATCH 0/3] files cancellation cleanup Jens Axboe
2021-01-22  9:45 ` Joseph Qi
2021-01-22 21:49   ` Pavel Begunkov [this message]
2021-01-25  2:14     ` Joseph Qi
2021-01-25 10:48       ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox