From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E7F1C433E0 for ; Fri, 22 Jan 2021 21:55:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E617223B31 for ; Fri, 22 Jan 2021 21:55:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730766AbhAVVyb (ORCPT ); Fri, 22 Jan 2021 16:54:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730312AbhAVVyE (ORCPT ); Fri, 22 Jan 2021 16:54:04 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54735C061788 for ; Fri, 22 Jan 2021 13:53:19 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id c124so5496565wma.5 for ; Fri, 22 Jan 2021 13:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XaiUwt4A7duLglVqeT69osARwibSCGNrycdsZHIFFwA=; b=HweZIH0zodBTH8fO6Ic/dE4VcO3uQfOt/bz8wMEQpNynS1RP25/JHjVRPWzJmAge98 BRp/BjeuyD1N0awZ3osCXz+PO1tuKm5z5oH9RDELolNuqiCR/1lH/Blzjogztxtqfnte NeXP/W1qRGLe5iaVH/i6NZlK3ZQlNeTSCujrLrfCmoVgQlWg/ki9/nzz3Ye8o1BP4Zbw PUEfoC8fhEt3oElLsMqbMckPnjlMF203zz5snJ/PZ9nljsfKGWygne810qAYNH7IrKLL CkDk2KWwuRSUnUU7BXCO8Gx63LNd8yje4cy0EtgTAjTDfEmAG2MRGNhUHp+FnVAP94Ht JzCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XaiUwt4A7duLglVqeT69osARwibSCGNrycdsZHIFFwA=; b=pKkXKS2NA5HXf5YTC9VZWASaNAm+Si/cHB57e7xVHVo8RUc/71SAN9KP+VIUqMZaxy y5E6VRssQUrqZ0kIERoZM1Ql0bMeJSD3DFZx+C9f77X9OiPTlOfs4lVXXTN0OcAnr/z9 6tZwlRa3dqVTvPlrXtPthrVT3bUJe4X4ZviO3Cz/7x8xWeS6ZLm9gfeB8RBX8ZEWrSbC 6bXMEWZpRvDuwVswg7YECLZerHFaqUkkr/6PNnTpoeNU8tp1sFR35NQ9dxxh69szk3o3 A6ZXAVj8EnC/nOGZuLcN3FMDWKS1KbGVeFc0bzhQ0Fd4rli7jcAL1RXuxSHXsqwAs3gr wOtg== X-Gm-Message-State: AOAM531dqVqy7oBwtAsGbfQgoNEBwuHlKs5EO6Qc+2hv3NhMRAjfCR0w f3umop6S3E3V+kJxTGe4zG1SFXfGtP1VEQ== X-Google-Smtp-Source: ABdhPJw/JwFztFM3cjzDfAs30MudP/sW1WbVRav+D7u2Jhv663MlVDilAybvGgM/jC6K5QQyv60dqw== X-Received: by 2002:a7b:c04c:: with SMTP id u12mr5871472wmc.185.1611352397703; Fri, 22 Jan 2021 13:53:17 -0800 (PST) Received: from [192.168.8.147] ([85.255.236.175]) by smtp.gmail.com with ESMTPSA id l1sm6357464wrp.40.2021.01.22.13.53.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 13:53:17 -0800 (PST) Subject: Re: [PATCH 0/3] files cancellation cleanup To: Joseph Qi , Jens Axboe , io-uring@vger.kernel.org References: <246d838d-0fce-d3c3-dcfc-9cbf9fa72de1@gmail.com> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Message-ID: <55e5491c-73c3-8d13-e3d1-056a2506f285@gmail.com> Date: Fri, 22 Jan 2021 21:49:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <246d838d-0fce-d3c3-dcfc-9cbf9fa72de1@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 22/01/2021 09:45, Joseph Qi wrote: > Seems this series can also resolve a possible deadlock case I'm looking > into. It removes dead code, I believe your issue is solved by ("io_uring: get rid of intermediate IORING_OP_CLOSE stage") https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.12/io_uring&id=7be8ba3b656cb4e0158b2c859b949f34a96aa94f Did you try this series in particular, or tested for-5.12/io_uring and see that the issue is gone there? > CPU0: > ... > io_kill_linked_timeout // &ctx->completion_lock > io_commit_cqring > __io_queue_deferred > __io_queue_async_work > io_wq_enqueue > io_wqe_enqueue // &wqe->lock > > CPU1: > ... > __io_uring_files_cancel > io_wq_cancel_cb > io_wqe_cancel_pending_work // &wqe->lock > io_cancel_task_cb // &ctx->completion_lock > > Thanks, > Joseph > > On 1/20/21 10:32 AM, Pavel Begunkov wrote: >> Carefully remove leftovers from removing cancellations by files >> >> Pavel Begunkov (3): >> io_uring: remove cancel_files and inflight tracking >> io_uring: cleanup iowq cancellation files matching >> io_uring: don't pass files for cancellation >> >> fs/io_uring.c | 168 ++++++++++---------------------------------------- >> 1 file changed, 32 insertions(+), 136 deletions(-) >> -- Pavel Begunkov