* [PATCH] io_uring/poll: disable level triggered poll
@ 2022-09-28 15:59 Jens Axboe
2022-09-28 21:11 ` Stefan Metzmacher
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2022-09-28 15:59 UTC (permalink / raw)
To: io-uring; +Cc: Stefan Metzmacher
Stefan reports that there are issues with the level triggered
notification. Since we're late in the cycle, and it was introduced for
the 6.0 release, just disable it at prep time and we can bring this
back when Samba is happy with it.
Reported-by: Stefan Metzmacher <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
---
diff --git a/io_uring/poll.c b/io_uring/poll.c
index d5bad0bea6e4..0d9f49c575e0 100644
--- a/io_uring/poll.c
+++ b/io_uring/poll.c
@@ -857,7 +857,7 @@ int io_poll_add_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
if (sqe->buf_index || sqe->off || sqe->addr)
return -EINVAL;
flags = READ_ONCE(sqe->len);
- if (flags & ~(IORING_POLL_ADD_MULTI|IORING_POLL_ADD_LEVEL))
+ if (flags & ~IORING_POLL_ADD_MULTI)
return -EINVAL;
if ((flags & IORING_POLL_ADD_MULTI) && (req->flags & REQ_F_CQE_SKIP))
return -EINVAL;
--
Jens Axboe
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] io_uring/poll: disable level triggered poll
2022-09-28 15:59 [PATCH] io_uring/poll: disable level triggered poll Jens Axboe
@ 2022-09-28 21:11 ` Stefan Metzmacher
2022-09-29 1:28 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Metzmacher @ 2022-09-28 21:11 UTC (permalink / raw)
To: Jens Axboe, io-uring
Hi Jens,
> Stefan reports that there are issues with the level triggered
> notification. Since we're late in the cycle, and it was introduced for
> the 6.0 release, just disable it at prep time and we can bring this
> back when Samba is happy with it.
>
> Reported-by: Stefan Metzmacher <[email protected]>
> Signed-off-by: Jens Axboe <[email protected]>
Also reviewed by me.
Thanks!
metze
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] io_uring/poll: disable level triggered poll
2022-09-28 21:11 ` Stefan Metzmacher
@ 2022-09-29 1:28 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-09-29 1:28 UTC (permalink / raw)
To: Stefan Metzmacher, io-uring
On 9/28/22 3:11 PM, Stefan Metzmacher wrote:
> Hi Jens,
>
>> Stefan reports that there are issues with the level triggered
>> notification. Since we're late in the cycle, and it was introduced for
>> the 6.0 release, just disable it at prep time and we can bring this
>> back when Samba is happy with it.
>>
>> Reported-by: Stefan Metzmacher <[email protected]>
>> Signed-off-by: Jens Axboe <[email protected]>
>
> Also reviewed by me.
Added, thanks!
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-29 1:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-28 15:59 [PATCH] io_uring/poll: disable level triggered poll Jens Axboe
2022-09-28 21:11 ` Stefan Metzmacher
2022-09-29 1:28 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox