From: "Fabio M. De Francesco" <[email protected]>
To: Ira Weiny <[email protected]>
Cc: Benjamin LaHaise <[email protected]>,
Alexander Viro <[email protected]>,
Eric Biederman <[email protected]>,
Kees Cook <[email protected]>,
Dan Williams <[email protected]>,
Matthew Wilcox <[email protected]>, Jan Kara <[email protected]>,
Jeff Layton <[email protected]>,
Chuck Lever <[email protected]>,
Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>,
Thomas Gleixner <[email protected]>,
Paul Walmsley <[email protected]>,
Palmer Dabbelt <[email protected]>,
Albert Ou <[email protected]>,
Nathan Chancellor <[email protected]>,
Nick Desaulniers <[email protected]>,
Tom Rix <[email protected]>,
[email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH] fs: Replace kmap{,_atomic}() with kmap_local_page()
Date: Sat, 09 Jul 2022 20:30:28 +0200 [thread overview]
Message-ID: <5600017.DvuYhMxLoT@opensuse> (raw)
In-Reply-To: <YsiQptk19txHrG4c@iweiny-desk3>
On venerdì 8 luglio 2022 22:18:35 CEST Ira Weiny wrote:
> On Thu, Jun 30, 2022 at 06:35:27PM +0200, Fabio M. De Francesco wrote:
> > The use of kmap() and kmap_atomic() are being deprecated in favor of
> > kmap_local_page().
> >
> > With kmap_local_page(), the mappings are per thread, CPU local and not
> > globally visible. Furthermore, the mappings can be acquired from any
> > context (including interrupts).
> >
> > Therefore, use kmap_local_page() in exec.c because these mappings are
per
> > thread, CPU local, and not globally visible.
> >
> > Tested with xfstests on a QEMU + KVM 32-bits VM booting a kernel with
> > HIGHMEM64GB enabled.
> >
> > Suggested-by: Ira Weiny <[email protected]>
>
> This looks good but there is a kmap_atomic() in this file which I _think_
can
> be converted as well. But that is good as a separate patch.
>
> Reviewed-by: Ira Weiny <[email protected]>
>
Thanks for your review!
I didn't notice that kmap_atomic(). I'll send a conversion with a separate
patch.
Fabio
prev parent reply other threads:[~2022-07-09 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 16:35 [PATCH] fs: Replace kmap{,_atomic}() with kmap_local_page() Fabio M. De Francesco
2022-06-30 17:38 ` Eric W. Biederman
2022-07-01 10:10 ` Fabio M. De Francesco
2022-07-08 20:18 ` Ira Weiny
2022-07-09 18:30 ` Fabio M. De Francesco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5600017.DvuYhMxLoT@opensuse \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox