Re: [PATCH v2 8/8] io_uring: drain based on allocates reqs

[Pavel Begunkov <asml.silence@gmail.com>]

On 5/13/25 11:37, Andy Shevchenko wrote:
> On Fri, May 09, 2025 at 12:12:54PM +0100, Pavel Begunkov wrote:
>> Don't rely on CQ sequence numbers for draining, as it has become messy
>> and needs cq_extra adjustments. Instead, base it on the number of
>> allocated requests and only allow flushing when all requests are in the
>> drain list.
>>
>> As a result, cq_extra is gone, no overhead for its accounting in aux cqe
>> posting, less bloating as it was inlined before, and it's in general
>> simpler than trying to track where we should bump it and where it should
>> be put back like in cases of overflow. Also, it'll likely help with
>> cleaning and unifying some of the CQ posting helpers.
> 
> This patch breaks the `make W=1` build. Please, always test your changes with

That's good advice, even if unsolicited, but it doesn't help with the
issue. Not every compiler complain. I'd also say, things like that
should warn by default, and they usually do, at least for basic
"unused variable" cases.

> `make W=1`. See below the details.

Yes, it's dead code and has already been fixed a day ago.

-- 
Pavel Begunkov