From: Pavel Begunkov <[email protected]>
To: Sidong Yang <[email protected]>, Jens Axboe <[email protected]>
Cc: Josef Bacik <[email protected]>,
David Sterba <[email protected]>,
[email protected], [email protected],
[email protected]
Subject: Re: [RFC PATCH v4 4/5] btrfs: ioctl: introduce btrfs_uring_import_iovec()
Date: Tue, 18 Mar 2025 07:25:51 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/18/25 01:58, Sidong Yang wrote:
> On Mon, Mar 17, 2025 at 09:40:05AM -0600, Jens Axboe wrote:
>> On 3/17/25 7:57 AM, Sidong Yang wrote:
>>> This patch introduces btrfs_uring_import_iovec(). In encoded read/write
>>> with uring cmd, it uses import_iovec without supporting fixed buffer.
>>> btrfs_using_import_iovec() could use fixed buffer if cmd flags has
>>> IORING_URING_CMD_FIXED.
>>>
>>> Signed-off-by: Sidong Yang <[email protected]>
>>> ---
>>> fs/btrfs/ioctl.c | 32 ++++++++++++++++++++++++--------
>>> 1 file changed, 24 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
>>> index 6c18bad53cd3..a7b52fd99059 100644
>>> --- a/fs/btrfs/ioctl.c
>>> +++ b/fs/btrfs/ioctl.c
>>> @@ -4802,6 +4802,28 @@ struct btrfs_uring_encoded_data {
>>> struct iov_iter iter;
>>> };
>>>
>>> +static int btrfs_uring_import_iovec(struct io_uring_cmd *cmd,
>>> + unsigned int issue_flags, int rw)
>>> +{
>>> + struct btrfs_uring_encoded_data *data =
>>> + io_uring_cmd_get_async_data(cmd)->op_data;
>>> + int ret;
>>> +
>>> + if (cmd && (cmd->flags & IORING_URING_CMD_FIXED)) {
>>> + data->iov = NULL;
>>> + ret = io_uring_cmd_import_fixed_vec(cmd, data->args.iov,
>>> + data->args.iovcnt,
>>> + ITER_DEST, issue_flags,
>>> + &data->iter);
>>> + } else {
>>> + data->iov = data->iovstack;
>>> + ret = import_iovec(rw, data->args.iov, data->args.iovcnt,
>>> + ARRAY_SIZE(data->iovstack), &data->iov,
>>> + &data->iter);
>>> + }
>>> + return ret;
>>> +}
>>
>> How can 'cmd' be NULL here?
>
> It seems that there is no checkes for 'cmd' before and it works same as before.
> But I think it's better to add a check in function start for safety.
The check goes two lines after you already dereferenced it, and it
seems to be called from io_uring cmd specific code. The null check
only adds to confusion.
--
Pavel Begunkov
next prev parent reply other threads:[~2025-03-18 7:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 13:57 [RFC PATCH v4 0/5] introduce io_uring_cmd_import_fixed_vec Sidong Yang
2025-03-17 13:57 ` [RFC PATCH v4 1/5] io_uring/cmd: introduce io_async_cmd for hide io_uring_cmd_data Sidong Yang
2025-03-17 13:57 ` [RFC PATCH v4 2/5] io-uring/cmd: add iou_vec field for io_uring_cmd Sidong Yang
2025-03-17 13:57 ` [RFC PATCH v4 3/5] io-uring/cmd: introduce io_uring_cmd_import_fixed_vec Sidong Yang
2025-03-17 13:57 ` [RFC PATCH v4 4/5] btrfs: ioctl: introduce btrfs_uring_import_iovec() Sidong Yang
2025-03-17 15:37 ` Caleb Sander Mateos
2025-03-18 0:51 ` Sidong Yang
2025-03-17 15:40 ` Jens Axboe
2025-03-18 1:58 ` Sidong Yang
2025-03-18 7:25 ` Pavel Begunkov [this message]
2025-03-18 7:55 ` Sidong Yang
2025-03-18 13:18 ` Jens Axboe
2025-03-17 13:57 ` [RFC PATCH v4 5/5] btrfs: ioctl: don't free iov when -EAGAIN in uring encoded read Sidong Yang
2025-03-18 7:21 ` Pavel Begunkov
2025-03-18 7:58 ` Sidong Yang
2025-03-18 7:30 ` [RFC PATCH v4 0/5] introduce io_uring_cmd_import_fixed_vec Pavel Begunkov
2025-03-18 7:41 ` Sidong Yang
2025-03-18 13:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox