Re: [PATCH v3 0/2] liburing: multishot timeout support

[Jens Axboe <axboe@kernel.dk>]

On 4/14/23 4:55?PM, David Wei wrote:
> Changes on the liburing side to support multishot timeouts.
> 
> Changes since v2:
> 
> * Edited man page for io_uring_prep_timeout.3
> 
> David Wei (2):
>   liburing: add multishot timeout support
>   liburing: update man page for multishot timeouts
> 
>  man/io_uring_prep_timeout.3     |   7 +
>  src/include/liburing/io_uring.h |   1 +
>  test/timeout.c                  | 263 ++++++++++++++++++++++++++++++++
>  3 files changed, 271 insertions(+)

I applied this, but there's an issue in that the tests don't just skip
if the kernel doesn't support multishot. Tests for liburing need to
accept that the feature isn't available on older kernels. Generally this
is done by the first test setting 'no_timeout_mshot = true' or something
like that, and then subsequent ones just returning T_SETUP_SKIP if
no_timeout_mshot == true and whatever calls the test not failing if
T_SETUP_SKIP is returned.

Would be great if you could send a followup patch against the current
liburing -git that does that. Thanks!

-- 
Jens Axboe