public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
	io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH] io_uring/msg_ring: kill alloc_cache for io_kiocb allocations
Date: Fri, 19 Sep 2025 08:51:19 -0600	[thread overview]
Message-ID: <57346868-0da1-49e0-834b-a5e5d26e7dc3@kernel.dk> (raw)
In-Reply-To: <23a67fd6-0179-4578-82ef-cf796bea4346@gmail.com>

On 9/19/25 8:06 AM, Pavel Begunkov wrote:
> On 9/18/25 21:04, Jens Axboe wrote:
>> A recent commit:
>>
>> fc582cd26e88 ("io_uring/msg_ring: ensure io_kiocb freeing is deferred for RCU")
>>
>> fixed an issue with not deferring freeing of io_kiocb structs that
> 
> I didn't care to mention before, but that patch was doing nothing
> meaningful, adding a second RCU grace period rarely solves anything.
> If you're curious what the problem most likely is, see

Yeah I forgot it's SLAB_TYPESAFE_BY_RCU already. At least now it's just being
yanked.

-- 
Jens Axboe


      reply	other threads:[~2025-09-19 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18 20:04 [PATCH] io_uring/msg_ring: kill alloc_cache for io_kiocb allocations Jens Axboe
2025-09-19 14:06 ` Pavel Begunkov
2025-09-19 14:51   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57346868-0da1-49e0-834b-a5e5d26e7dc3@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox