From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FA0CC433EF for ; Thu, 9 Sep 2021 13:12:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11101611CA for ; Thu, 9 Sep 2021 13:12:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355621AbhIINN6 (ORCPT ); Thu, 9 Sep 2021 09:13:58 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:48201 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355494AbhIINB7 (ORCPT ); Thu, 9 Sep 2021 09:01:59 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=haoxu@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UnnZGPn_1631192447; Received: from B-25KNML85-0107.local(mailfrom:haoxu@linux.alibaba.com fp:SMTPD_---0UnnZGPn_1631192447) by smtp.aliyun-inc.com(127.0.0.1); Thu, 09 Sep 2021 21:00:48 +0800 Subject: Re: [PATCH] io-wq: fix memory leak in create_io_worker() To: Jens Axboe Cc: io-uring@vger.kernel.org, Pavel Begunkov , Joseph Qi References: <20210909040507.82711-1-haoxu@linux.alibaba.com> From: Hao Xu Message-ID: <574bb7cd-c0e4-14d3-8afa-2f892a7b78bd@linux.alibaba.com> Date: Thu, 9 Sep 2021 21:00:47 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org 在 2021/9/9 下午8:57, Jens Axboe 写道: > On 9/8/21 10:05 PM, Hao Xu wrote: >> We should free memory the variable worker point to in fail path. > > I think this one is missing a few paths where it can also happen, once > punted. True. I browse the code again and I think Qiang.zhang's patch should be fine. >