public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, io-uring <[email protected]>
Subject: Re: [PATCH] io_uring: kill io_cqring_ev_posted() and __io_cq_unlock_post()
Date: Thu, 24 Nov 2022 19:19:22 +0000	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 11/24/22 19:17, Pavel Begunkov wrote:
> On 11/24/22 18:46, Jens Axboe wrote:
>> On 11/24/22 9:16?AM, Pavel Begunkov wrote:
>>> On 11/21/22 14:52, Jens Axboe wrote:
>>>> __io_cq_unlock_post() is identical to io_cq_unlock_post(), and
>>>> io_cqring_ev_posted() has a single caller so migth as well just inline
>>>> it there.
>>>
>>> It was there for one purpose, to inline it in the hottest path,
>>> i.e. __io_submit_flush_completions(). I'll be reverting it back
>>
>> The compiler is most certainly already doing that, in fact even
> 
> .L1493:
> # io_uring/io_uring.c:631:     io_cq_unlock_post(ctx);
>      movq    %r15, %rdi    # ctx,
>      call    io_cq_unlock_post    #

wrong one,

__io_submit_flush_completions:
	pushq	%rbp	#
...
.L1793:
# io_uring/io_uring.c:1394: 	io_cq_unlock_post(ctx);
	movq	%r12, %rdi	# ctx,
	call	io_cq_unlock_post	#


> Even more, after IORING_SETUP_CQE32 was added I didn't see
> once __io_fill_cqe_req actually inlined even though it's marked
> so.
> 
>> __io_submit_flush_completions() is inlined in
>> io_submit_flush_completions() for me here.
> 
> And io_submit_flush_completions is inlined as well, right?
> That would be quite odd, __io_submit_flush_completions() is not
> small by any means and there are 3 call sites.
> 

-- 
Pavel Begunkov

  reply	other threads:[~2022-11-24 19:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 14:52 [PATCH] io_uring: kill io_cqring_ev_posted() and __io_cq_unlock_post() Jens Axboe
2022-11-24 16:16 ` Pavel Begunkov
2022-11-24 18:46   ` Jens Axboe
2022-11-24 19:17     ` Pavel Begunkov
2022-11-24 19:19       ` Pavel Begunkov [this message]
2022-11-24 19:29       ` Jens Axboe
2022-11-24 19:51         ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox