public inbox for [email protected]
 help / color / mirror / Atom feed
From: Dylan Yudaken <[email protected]>
To: "[email protected]" <[email protected]>
Cc: Kernel Team <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>,
	"[email protected]" <[email protected]>
Subject: Re: [PATCH liburing 5/5] overflow: add tests
Date: Thu, 21 Apr 2022 13:04:04 +0000	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Thu, 2022-04-21 at 18:44 +0700, Ammar Faizi wrote:
> On 4/21/22 4:14 PM, Dylan Yudaken wrote:
> > Add tests that verify that overflow conditions behave
> > appropriately.
> > Specifically:
> >   * if overflow is continually flushed, then CQEs should arrive
> > mostly in
> >   order to prevent starvation of some completions
> >   * if CQEs are dropped due to GFP_ATOMIC allocation failures it is
> >   possible to terminate cleanly. This is not tested by default as
> > it
> >   requires debug kernel config, and also has system-wide effects
> > 
> > Signed-off-by: Dylan Yudaken <[email protected]>
> > ---
> 
> Dylan, this breaks -Werror build with clang-15.
> 
> ```
>    cq-overflow.c:188:15: error: variable 'drop_count' set but not
> used [-Werror,-Wunused-but-set-variable]
>            unsigned int drop_count = 0;
>                         ^
>    1 error generated.
>    make[1]: *** [Makefile:210: cq-overflow.t] Error 1
>    make[1]: *** Waiting for unfinished jobs....
> ```
> 
> Maybe you miss something that you forgot to use the value of
> @drop_count?
> 

Ah - I had some debug statements that were using it but did not remove
it when removing those (the versions of gcc/clang I have do not
complain). I will clean it up in v2.
Thanks for spotting it!

  reply	other threads:[~2022-04-21 13:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21  9:14 [PATCH liburing 0/5] overflow support Dylan Yudaken
2022-04-21  9:14 ` [PATCH liburing 1/5] fix documentation shortenings Dylan Yudaken
2022-04-21  9:14 ` [PATCH liburing 2/5] update io_uring_enter.2 docs for IORING_FEAT_NODROP Dylan Yudaken
2022-04-21  9:14 ` [PATCH liburing 3/5] expose CQ ring overflow state Dylan Yudaken
2022-04-21  9:14 ` [PATCH liburing 4/5] add docs for overflow lost errors Dylan Yudaken
2022-04-21  9:14 ` [PATCH liburing 5/5] overflow: add tests Dylan Yudaken
2022-04-21 11:44   ` Ammar Faizi
2022-04-21 13:04     ` Dylan Yudaken [this message]
2022-04-21 19:49   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58eb54d2d596b5f9ffbed4b3e82848de1fa77b80.camel@fb.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox