From: Pavel Begunkov <asml.silence@gmail.com>
To: Caleb Sander Mateos <csander@purestorage.com>,
Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] io_uring/net: use REQ_F_IMPORT_BUFFER for send_zc
Date: Wed, 26 Mar 2025 09:59:49 +0000 [thread overview]
Message-ID: <5b6b20d7-5230-4d30-b457-4d69c1bb51d4@gmail.com> (raw)
In-Reply-To: <20250325143943.1226467-1-csander@purestorage.com>
On 3/25/25 14:39, Caleb Sander Mateos wrote:
> Instead of a bool field in struct io_sr_msg, use REQ_F_IMPORT_BUFFER to
> track whether io_send_zc() has already imported the buffer. This flag
> already serves a similar purpose for sendmsg_zc and {read,write}v_fixed.
It didn't apply cleanly to for-6.15/io_uring-reg-vec, but otherwise
looks good.
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
> Suggested-by: Pavel Begunkov <asml.silence@gmail.com>
Note for the future, it's a good practice to put your sob last.
--
Pavel Begunkov
next prev parent reply other threads:[~2025-03-26 9:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 14:39 [PATCH v2] io_uring/net: use REQ_F_IMPORT_BUFFER for send_zc Caleb Sander Mateos
2025-03-26 9:59 ` Pavel Begunkov [this message]
2025-03-26 17:01 ` Caleb Sander Mateos
2025-03-26 17:05 ` Jens Axboe
2025-03-26 17:23 ` Caleb Sander Mateos
2025-03-26 17:31 ` Jens Axboe
2025-03-26 22:41 ` Pavel Begunkov
2025-03-26 22:31 ` Pavel Begunkov
2025-03-26 17:05 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b6b20d7-5230-4d30-b457-4d69c1bb51d4@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox