From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Cc: Caleb Sander Mateos <[email protected]>
Subject: Re: [PATCH 1/1] io_uring/waitid: don't abuse io_tw_state
Date: Wed, 12 Feb 2025 07:31:23 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <9857d8768ee689f515c6f12b3ec5842c545c8959.1739367134.git.asml.silence@gmail.com>
On 2/12/25 6:33 AM, Pavel Begunkov wrote:
> struct io_tw_state is managed by core io_uring, and opcode handling code
> must never try to cheat and create their own instances, it's plain
> incorrect.
>
> io_waitid_complete() attempts exactly that outside of the task work
> context, and even though the ring is locked, there would be no one to
> reap the requests from the defer completion list. It only works now
> because luckily it's called before io_uring_try_cancel_uring_cmd(),
> which flushes completions.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2025-02-12 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 13:33 [PATCH 1/1] io_uring/waitid: don't abuse io_tw_state Pavel Begunkov
2025-02-12 14:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox