public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Anuj gupta <anuj1072538@gmail.com>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
	Anuj Gupta <anuj20.g@samsung.com>,
	io-uring@vger.kernel.org, joshi.k@samsung.com
Subject: Re: [PATCH liburing] test/io_uring_passthrough: add test for vectored fixed-buffers
Date: Wed, 21 May 2025 08:24:25 -0600	[thread overview]
Message-ID: <5baf3782-f9f5-4da0-961b-ebff7579ff2c@kernel.dk> (raw)
In-Reply-To: <CACzX3AsdtuTuxXU+GUdh_GWPJUhuEM4uiTSHJFtHMqMogvxOtg@mail.gmail.com>

On 5/21/25 8:20 AM, Anuj gupta wrote:
>>> Regarding the vectored I/O being limited to 1 iovec ? yeah, I kept it
>>> simple initially because the plumbing was easier that way. It?s the same
>>> in test/read-write.c, where vectored calls also use just one iovec. But
>>> I agree, for better coverage, it makes sense to test with multiple
>>> iovecs. I?ll prepare and post a follow-up patch that adds that.
>>
>> We really should ensure it exercises at least the three common types
>> for iovec imports:
>>
>> 1) Single segment
>> 2) Multi segment, but below dynamic alloc range
>> 3) Multi segment, above (or equal) to dynamic alloc range
>>
>> These days 2+3 are the same thing, so makes it a bit easier, as we
>> just embed a single vec.
>>
>> Bonus points if you want to send followup patches for both the
>> passthrough and read-write case using eg 4 segments or something
>> like that.
>>
> 
> Thanks, Jens. Makes sense.
> I’ll follow up with patches to cover all those vectored I/O cases.

Great, thanks!

-- 
Jens Axboe


  reply	other threads:[~2025-05-21 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250521083658epcas5p2c2d23dbcfac4242343365bb85301c5ea@epcas5p2.samsung.com>
2025-05-21  8:19 ` [PATCH liburing] test/io_uring_passthrough: add test for vectored fixed-buffers Anuj Gupta
2025-05-21  9:42   ` Pavel Begunkov
2025-05-21 10:35     ` Anuj gupta
2025-05-21 13:08       ` Jens Axboe
2025-05-21 14:20         ` Anuj gupta
2025-05-21 14:24           ` Jens Axboe [this message]
2025-05-21 14:05       ` Pavel Begunkov
2025-05-21 14:14         ` Jens Axboe
2025-05-21 14:46           ` Pavel Begunkov
2025-05-21 14:51             ` Jens Axboe
2025-05-21 13:08   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5baf3782-f9f5-4da0-961b-ebff7579ff2c@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=anuj1072538@gmail.com \
    --cc=anuj20.g@samsung.com \
    --cc=asml.silence@gmail.com \
    --cc=io-uring@vger.kernel.org \
    --cc=joshi.k@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox