From: Stefan Roesch <[email protected]>
To: Christian Brauner <[email protected]>
Cc: <[email protected]>, <[email protected]>,
<[email protected]>, <[email protected]>
Subject: Re: [PATCH v9 1/5] fs: split off do_user_path_at_empty from user_path_at_empty()
Date: Wed, 29 Dec 2021 12:34:16 -0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20211229143126.advkumqim7tztlmq@wittgenstein>
On 12/29/21 6:31 AM, Christian Brauner wrote:
> On Tue, Dec 28, 2021 at 10:41:41AM -0800, Stefan Roesch wrote:
>> This splits off a do_user_path_at_empty function from the
>> user_path_at_empty_function. This is required so it can be
>> called from io_uring.
>>
>> Signed-off-by: Stefan Roesch <[email protected]>
>> Acked-by: Christian Brauner <[email protected]>
>> ---
>> fs/namei.c | 10 ++++++++--
>> include/linux/namei.h | 2 ++
>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/namei.c b/fs/namei.c
>> index 1f9d2187c765..d988e241b32c 100644
>> --- a/fs/namei.c
>> +++ b/fs/namei.c
>> @@ -2794,12 +2794,18 @@ int path_pts(struct path *path)
>> }
>> #endif
>>
>> +int do_user_path_at_empty(int dfd, struct filename *filename, unsigned int flags,
>> + struct path *path)
>> +{
>> + return filename_lookup(dfd, filename, flags, path, NULL);
>> +}
>> +
>> int user_path_at_empty(int dfd, const char __user *name, unsigned flags,
>> - struct path *path, int *empty)
>> + struct path *path, int *empty)
>> {
>> struct filename *filename = getname_flags(name, flags, empty);
>> - int ret = filename_lookup(dfd, filename, flags, path, NULL);
>>
>> + int ret = do_user_path_at_empty(dfd, filename, flags, path);
>> putname(filename);
>> return ret;
>> }
>> diff --git a/include/linux/namei.h b/include/linux/namei.h
>> index e89329bb3134..8f3ef38c057b 100644
>> --- a/include/linux/namei.h
>> +++ b/include/linux/namei.h
>> @@ -49,6 +49,8 @@ enum {LAST_NORM, LAST_ROOT, LAST_DOT, LAST_DOTDOT};
>>
>> extern int path_pts(struct path *path);
>>
>> +extern int do_user_path_at_empty(int dfd, struct filename *filename,
>> + unsigned int flags, struct path *path);
>
> Sorry, just seeing this now but this wants to live in internal.h not in
> namei.h similar to all the other io_uring specific exports we added over
> the last releases. There's no need to make this a kernel-wide thing if
> we can avoid it, imho. With that changed:
> Acked-by: Christian Brauner <[email protected]>
I moved the declaration to fs/internal.h.
>
next prev parent reply other threads:[~2021-12-29 20:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 18:41 [PATCH v9 0/5] io_uring: add xattr support Stefan Roesch
2021-12-28 18:41 ` [PATCH v9 1/5] fs: split off do_user_path_at_empty from user_path_at_empty() Stefan Roesch
2021-12-29 14:31 ` Christian Brauner
2021-12-29 20:34 ` Stefan Roesch [this message]
2021-12-28 18:41 ` [PATCH v9 2/5] fs: split off setxattr_copy and do_setxattr function from setxattr Stefan Roesch
2021-12-29 14:48 ` Christian Brauner
2021-12-28 18:41 ` [PATCH v9 3/5] fs: split off do_getxattr from getxattr Stefan Roesch
2021-12-28 18:41 ` [PATCH v9 4/5] io_uring: add fsetxattr and setxattr support Stefan Roesch
2021-12-29 14:51 ` Christian Brauner
2021-12-29 20:35 ` Stefan Roesch
2021-12-28 18:41 ` [PATCH v9 5/5] io_uring: add fgetxattr and getxattr support Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox