From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH 1/1] io_uring: don't leak creds on SQO attach error
Date: Thu, 18 Mar 2021 07:23:52 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <7c7e783bbc4b785825b159d4172527de0014ebc2.1616066965.git.asml.silence@gmail.com>
On 3/18/21 5:54 AM, Pavel Begunkov wrote:
> Attaching to already dead/dying SQPOLL task is disallowed in
> io_sq_offload_create(), but cleanup is hand coded by calling
> io_put_sq_data()/etc., that miss to put ctx->sq_creds.
>
> Defer everything to error-path io_sq_thread_finish(), adding
> ctx->sqd_list in the error case as well as finish will handle it.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-03-18 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 11:54 [PATCH 1/1] io_uring: don't leak creds on SQO attach error Pavel Begunkov
2021-03-18 13:23 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox