Re: [PATCH v3 0/2] io-uring: Make statx api stable

[Marek Szyprowski <m.szyprowski@samsung.com>]

Hi,

On 22.02.2022 19:45, Jens Axboe wrote:
> On Tue, 15 Feb 2022 10:03:26 -0800, Stefan Roesch wrote:
>> One of the key architectual tenets of io-uring is to keep the
>> parameters for io-uring stable. After the call has been submitted,
>> its value can be changed.  Unfortunaltely this is not the case for
>> the current statx implementation.
>>
>> Patches:
>>   Patch 1: fs: replace const char* parameter in vfs_statx and do_statx with
>>            struct filename
>>     Create filename object outside of do_statx and vfs_statx, so io-uring
>>     can create the filename object during the prepare phase
>>
>> [...]
> Applied, thanks!
>
> [1/2] fs: replace const char* parameter in vfs_statx and do_statx with struct filename
>        commit: 30512d54fae354a2359a740b75a1451b68aa3807
> [2/2] io-uring: Copy path name during prepare stage for statx
>        commit: 1e0561928e3ab5018615403a2a1293e1e44ee03e

Those 2 commits landed in todays Linux next-20220223. They affect 
userspace in a way that breaks systemd opration:

...

Freeing unused kernel image (initmem) memory: 1024K
Run /sbin/init as init process
systemd[1]: System time before build time, advancing clock.
systemd[1]: Cannot be run in a chroot() environment.
systemd[1]: Freezing execution.

Reverting them on top of next-20220223 fixes the boot issue. Btw, those 
patches are not bisectable. The code at 
30512d54fae354a2359a740b75a1451b68aa3807 doesn't compile.


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland