public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH] io_uring: Fix linked fixed-read/write
Date: Sat, 23 Nov 2019 15:52:12 -0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <38fe471ecc3212c334fa60ff88a73896f11ec355.1574548888.git.asml.silence@gmail.com>

On 11/23/19 3:42 PM, Pavel Begunkov wrote:
> Dependant links of a fixed-read/write are always cancelled. The reason
> is that io_complete_rw_common() uses req->result to decide whether to
> fail links, which is set as res=io_import_iovec(). However,
> io_import_fixed() doesn't return size, but error code.

See:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5e559561a8d7e6d4adfce6aa8fbf3daa3dec1577

Just not in the 5.5 branches. We probably do want to make it ssize_t to
be more proper, but IO in Linux is capped at 2G anyway so doesn't make
a difference right now.

-- 
Jens Axboe


      reply	other threads:[~2019-11-23 22:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 22:42 [PATCH] io_uring: Fix linked fixed-read/write Pavel Begunkov
2019-11-23 22:52 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox