From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 826AAC433EF for ; Fri, 3 Sep 2021 12:16:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FAAB60E8B for ; Fri, 3 Sep 2021 12:16:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348767AbhICMR5 (ORCPT ); Fri, 3 Sep 2021 08:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235165AbhICMR4 (ORCPT ); Fri, 3 Sep 2021 08:17:56 -0400 Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D68C3C061575 for ; Fri, 3 Sep 2021 05:16:56 -0700 (PDT) Received: by mail-il1-x131.google.com with SMTP id b4so4990814ilr.11 for ; Fri, 03 Sep 2021 05:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=09TsPIb4fXxY2VJx6kdGXIqWorLQ2YYQZCBibzSAYxI=; b=p1Sk/HqyZvS2/jQ16k+A7jzv5x5BnKiB/RxQegu2rH8Ld7j57FDdequtGt21jUW68/ cuXINnFJsylSpRWjnRELUe+nZ8ANYCoTSF1kOYtUdXYCn/C/znxsaqt7oK0qFNlDJNPE XiaVaY4SvPTuk0/KwmryQz/hahFjlfh/RXsn0yLdvwn/r3RpWy6N2zyQ2fw4N7esGclw m5JJzZ/G3um+Izf6Wert7LUbilXZpPx7nKemuYG9EvJI5Fbq3WVaOO+xA3kZxbC4x5fr DRSL7v7NeMftcUxL1XqvKV0pCsOFaeiRdbORvzwe/uY2GxNkzTG9dpAjQVfoH3nKJ8B5 51dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=09TsPIb4fXxY2VJx6kdGXIqWorLQ2YYQZCBibzSAYxI=; b=PW54WdRGciufJoPWzN5CFmqP3336oZQ/k/FcT7ZHejaa92lSXUT+kRc5R2gyoxJ9lh J0mbAZqCqvJcdWyas2xIMLhPyx+Q+wmvoPqz6bMRnOwC2s+/szz9qPho5O7OcAh5UfJ8 B1d2bKOE2ekDUKz43Amkq2CiuuOfd4mUTcX2UtJ2YbRhZccQ1kQ2maORRCuOOeoXevFt Ygbe3GPaziByU26tKaKyCahXZ8HZQJypCfGAFGyOZ471+opZbfUyKal1Nd/wHQXqX2Bj 5M0Ebo5cB4C8THWryAN3AMNH4my+DjjlllspENNTXI7FU9WEd/7NTQd1fKsW6x8cFCwo uKUw== X-Gm-Message-State: AOAM53065UEV8tBHk5iNvKQRwCTJPJTqri7ZTocQgNYYzw0Mk7a9dd9i Bc4eLJOe8IMpLoPFVApyFA/JV41mKW2/NQ== X-Google-Smtp-Source: ABdhPJzhrMWpgAMLYtf5fDP9/i+XboM6XjtDoWIc9/UebbNznBIVEADHycSo0YpoUxqaMuDE1qurIg== X-Received: by 2002:a05:6e02:524:: with SMTP id h4mr2321673ils.203.1630671416183; Fri, 03 Sep 2021 05:16:56 -0700 (PDT) Received: from [192.168.1.116] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id z6sm2532738ilp.9.2021.09.03.05.16.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 05:16:55 -0700 (PDT) Subject: Re: [PATCH][next] io_uring: Fix a read of ununitialized pointer tctx To: Colin King , Pavel Begunkov , io-uring@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210903113535.11257-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <5e5e1bb9-c5d3-d668-8a61-f70538ef92df@kernel.dk> Date: Fri, 3 Sep 2021 06:16:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210903113535.11257-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 9/3/21 5:35 AM, Colin King wrote: > From: Colin Ian King > > In the unlikely case where ctx->flags & IORING_SETUP_SQPOLL is true > and sqd is NULL the pointer tctx is not assigned a valid value and > can contain a garbage value when it is dereferenced. Fix this by > initializing it to NULL. Doh - thanks, I folded this one in. -- Jens Axboe