From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 534C6C6FD1D for ; Wed, 15 Mar 2023 15:16:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232455AbjCOPQO (ORCPT ); Wed, 15 Mar 2023 11:16:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232115AbjCOPQN (ORCPT ); Wed, 15 Mar 2023 11:16:13 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0A3AEFAA for ; Wed, 15 Mar 2023 08:16:12 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id r4so10540012ila.2 for ; Wed, 15 Mar 2023 08:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; t=1678893372; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OqTD8SXreFBDfGk9Towq94DfzLHb+0jZ+UAuwsdvyrs=; b=DbiyGXz9qNPL9QXHwATP3nJqJD2SOEpz+3WaNAmXAdDOSa+6PxebjQKSFjdsDoeRE+ EIzlkSKsmmR4+tGB/OC3K3yeg5CwKJVfpy0abETQ4j6ia7JV/YFHjz9fkVwjVVT01+gA 7hoTqPwikzgMhBd/IbtsFOtMFDRt2iakGIh7tF/Hp36/nEeqS3td0uU7ijfWTNGe3lQf mO/JICzYF/5eaBS6SyIKhBxE09oXgH9dGuorB80FRmWmsNxCDXLXMHnN3HjXwVPS92vD xmBgUmXZM0FRqioXTgQ/Xi/HnDcga3X6gKhnw5onh2R+vWCwNGZHnZ3sNJ0wB+9/X8Dk VEhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678893372; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OqTD8SXreFBDfGk9Towq94DfzLHb+0jZ+UAuwsdvyrs=; b=iuYAaTMOeiMdth6KSgxYbb48lDkc3nndWmSgcpDQKgYlMe8sgnEtkZCOyMCppx0rKH 6RQXQa8yBgHAYb5VqKKo5Mw9LceGTaOk7c4w52njR6R+6jWFioDSm95PgYMNwstla7e+ MRKlMklkzeVclQTBbrHAFKtDE+Jv5Qtlx8jlvmdR3Y2tbQBx/rUNdu+AQeO9cdStRHPT enUKg2Cz9P7I2DY4ih9+7IagRTuYt+q2W+4q57lPSkE0QfDGz4sVOjLg75rEBr+3ffCL +BrvbtbizgGZ8nEYiYHZzg2U2apwBR/2EGTzyb1up6x4E0bI3I5T+T9GhaVCGtvf/oGw Itrw== X-Gm-Message-State: AO0yUKVhDy/QttgV69ysiG9npG97zT0gVFvFxu3YzBL8AOKsTShU26tW qo7b8ox4jZMGglTg7K/Fug5c+g== X-Google-Smtp-Source: AK7set9D+WVhXnH07DQJu8SFuTg0UgCSR7HRh/a4BCorTjYCvv5e7XLeWp1lkbRIw8v0oOj0MKiCfA== X-Received: by 2002:a92:7406:0:b0:322:fad5:5d8f with SMTP id p6-20020a927406000000b00322fad55d8fmr7964989ilc.2.1678893372045; Wed, 15 Mar 2023 08:16:12 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id y17-20020a056e02119100b0031798b87a14sm1696387ili.19.2023.03.15.08.16.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 08:16:11 -0700 (PDT) Message-ID: <5e740404-0890-cf34-94fd-7b929a048f6d@kernel.dk> Date: Wed, 15 Mar 2023 09:16:10 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/3] pipe: enable handling of IOCB_NOWAIT Content-Language: en-US From: Jens Axboe To: Christian Brauner Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, Dave Chinner References: <20230314154203.181070-1-axboe@kernel.dk> <20230314154203.181070-3-axboe@kernel.dk> <20230315082321.47mw5essznhejv7z@wittgenstein> <38781e4c-29b7-2fbc-44a9-f365189f5381@kernel.dk> <20230315150237.iwhoj7a3nb4vwazd@wittgenstein> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 3/15/23 9:12 AM, Jens Axboe wrote: > On 3/15/23 9:02 AM, Christian Brauner wrote: >> On Wed, Mar 15, 2023 at 08:16:19AM -0600, Jens Axboe wrote: >>> On 3/15/23 2:23 AM, Christian Brauner wrote: >>>> On Tue, Mar 14, 2023 at 09:42:02AM -0600, Jens Axboe wrote: >>>>> In preparation for enabling FMODE_NOWAIT for pipes, ensure that the read >>>>> and write path handle it correctly. This includes the pipe locking, >>>>> page allocation for writes, and confirming pipe buffers. >>>>> >>>>> Acked-by: Dave Chinner >>>>> Signed-off-by: Jens Axboe >>>>> --- >>>> >>>> Looks good, >>>> Reviewed-by: Christian Brauner >>> >>> Thanks for the review, I'll add that. Are you OK with me carrying >>> these patches, or do you want to stage them for 6.4? >> >> I'n not fuzzed. Since it's fs only I would lean towards carrying it. I >> can pick it up now and see if Al has any strong opinions on this one. > > Either way is fine with me - let me know if you pick it up, and > I can drop it from my tree. Oh and if you do, I should probably send out a v3. Was missing a kerneldoc in patch 1, corrected that in my tree but it's not in v2. Outside of that one-liner doc change, same patches in my tree. -- Jens Axboe