From: Jens Axboe <[email protected]>
To: Nadav Amit <[email protected]>
Cc: [email protected], Hao Xu <[email protected]>
Subject: Re: Race between io_wqe_worker() and io_wqe_wake_worker()
Date: Tue, 3 Aug 2021 13:24:36 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 8/3/21 1:20 PM, Nadav Amit wrote:
>
>
>> On Aug 3, 2021, at 11:14 AM, Jens Axboe <[email protected]> wrote:
>>
>> On 8/3/21 12:04 PM, Nadav Amit wrote:
>>>
>>>
>>> Thanks for the quick response.
>>>
>>> I tried you version. It works better, but my workload still gets stuck
>>> occasionally (less frequently though). It is pretty obvious that the
>>> version you sent still has a race, so I didn’t put the effort into
>>> debugging it.
>>
>> All good, thanks for testing! Is it a test case you can share? Would
>> help with confidence in the final solution.
>
> Unfortunately no, since it is an entire WIP project that I am working
> on (with undetermined license at this point). But I will be happy to
> test any solution that you provide.
OK no worries, I'll see if I can tighten this up. I don't particularly
hate your solution, it would just be nice to avoid creating a new worker
if we can just keep running the current one.
I'll toss something your way in a bit...
--
Jens Axboe
next prev parent reply other threads:[~2021-08-03 19:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 1:05 Race between io_wqe_worker() and io_wqe_wake_worker() Nadav Amit
2021-08-03 13:22 ` Jens Axboe
2021-08-03 14:37 ` Jens Axboe
2021-08-03 17:25 ` Hao Xu
2021-08-03 18:04 ` Nadav Amit
2021-08-03 18:14 ` Jens Axboe
2021-08-03 19:20 ` Nadav Amit
2021-08-03 19:24 ` Jens Axboe [this message]
2021-08-03 19:53 ` Jens Axboe
2021-08-03 21:16 ` Nadav Amit
2021-08-03 21:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox