From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94EEAC54EEB for ; Mon, 23 Mar 2020 15:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67A7E20714 for ; Mon, 23 Mar 2020 15:57:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="ldgxYSTa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727364AbgCWP53 (ORCPT ); Mon, 23 Mar 2020 11:57:29 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:35688 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727298AbgCWP53 (ORCPT ); Mon, 23 Mar 2020 11:57:29 -0400 Received: by mail-pl1-f195.google.com with SMTP id g6so6092642plt.2 for ; Mon, 23 Mar 2020 08:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/xdFeUkMil+HXZ4ax6FoPNFtoFq6FUJmJ0Q6Zva1VrE=; b=ldgxYSTapIFo5c9XASqPk/M1zo3L8kU4x3tLHAuxMZ3Ni6aYrfoaqEhE+GIihzMifA hKtcxmeGZgwq3VV21jgiUJ/leOO59zn8qHUpukZvTMgPXL0f50oYzRetsOj5RfOr5wo6 hNb2+NEVCcjd2OVVKPiwQIVBfHMX/axtpRPHrL0Iv2sk/crj1nPyEJwsltNo8Ft5pDwy j8dYEZs68r93tzXRFm63Z6c5zJYZSdMkjkPqi11eaw/AP3CgE2ixd1CcjUbk8aUlSkpP zPNYtlRNtuG03yRkgo7ud3aFj9FsPNJD68IweJ+zZQXlexokaVicwjJKyLBKLNp4g1CL +DSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/xdFeUkMil+HXZ4ax6FoPNFtoFq6FUJmJ0Q6Zva1VrE=; b=WH5UgAqL/ww9VlaSlox/Qki/w0X1a1w2DhFgIX1Xrou+aHoMZtPYJiLyXu6APMz6jm l9kBBVWbDDdQ0ChPCMe+u+Egk6nucwnTEXEEVFxJvq2Dj4EJ73mtjW/pUf/OX2h3zZPO 8LDd/ZsMY2Eh6mPQ/8nedJsZyIs5TMbEm+uJYow3J0gUgDfXj5M3BmsOJTHzgnrLg0oz jCdiUKOeQOtGjHuhBP8vxU82vO2iTF1uqDdvUcxj71g3t7NRXUwb7JbXZAGlksAkdu+d 2gNyVj9KppqCSSZ6zwtjxv2eiYKjUuF4XmKbOasRtDWqEzjAdNAWPDHAV5tRSskEPxCG S3xQ== X-Gm-Message-State: ANhLgQ2cmJ6QiUOM3djqm03nPqHnqOcsJCCix5uKYRu6/JlNZWNMi9Uo OAWtsmXMBMl1uc89SAL8c5sdYQ== X-Google-Smtp-Source: ADFU+vv2vW47TMHyado3xCQbCSqIX92ldURxbW69S9I1oeWxT4bL7zUy0acMpY+x/kqHktNpZ7+cSw== X-Received: by 2002:a17:90a:2a89:: with SMTP id j9mr7994pjd.64.1584979048199; Mon, 23 Mar 2020 08:57:28 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id c62sm13653239pfc.136.2020.03.23.08.57.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2020 08:57:27 -0700 (PDT) Subject: Re: [PATCH 0/2] io-uring: cleanup: drop completion upon removal of file To: Hillf Danton Cc: syzbot , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk References: <20200323092419.8764-1-hdanton@sina.com> From: Jens Axboe Message-ID: <5f98097a-b3f7-fc8f-4a84-f848253a0e56@kernel.dk> Date: Mon, 23 Mar 2020 09:57:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200323092419.8764-1-hdanton@sina.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 3/23/20 3:24 AM, Hillf Danton wrote: > > Kudos to the task hung reported by syzbot, and inspired by it, cleanup > is made for dropping completion when files are removed from the fixed > fileset. Another cleanup is also proposed for dropping the done field > in struct io_file_put. > > [PATCH 1/2] io_uring: drop completion when removing file > [PATCH 2/2 RFC] io-uring: drop done in struct io_file_put I like it - I applied, only changing 'done' to 'free_pfile' to make it more apparent what it controls. Thanks! -- Jens Axboe