Re: [PULL|PATCH v3 0/7] liburing debian packaging fixes

[Stefan Metzmacher <metze@samba.org>]

Am 04.04.22 um 18:13 schrieb Stefan Metzmacher:
> 
> Am 03.04.22 um 16:54 schrieb Jens Axboe:
>> On 4/3/22 2:48 AM, Eric Wong wrote:
>>> Eric Wong <e@80x24.org> wrote:
>>>> The previous patch 8/7 in v2 is squashed into 3/7 in this series.
>>>> Apologies for the delay since v2, many bad things happened :<
>>>>
>>>> The following changes since commit bbcaabf808b53ef11ad9851c6b968140fb430500:
>>>>
>>>>    man/io_uring_enter.2: make it clear that chains terminate at submit (2022-01-19 18:09:40 -0700)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>    https://yhbt.net/liburing.git deb-v3
>>>>
>>>> for you to fetch changes up to 77b99bb1dbe237eef38eceb313501a9fd247d672:
>>>>
>>>>    make-debs: remove dependency on git (2022-01-21 16:54:42 +0000)
>>>
>>> Hi Jens, have you had a chance to look at this series?  Thanks.
>>> I mostly abandoned hacking for a few months :x
>>
>> I never build distro packages and know very little about it, so would
>> really like Stefan et al to sign off on this. I'm about to cut the next
>> version of liburing, and would indeed be great to have better packaging
>> sorted before that.
>>
>> Does it still apply to the curren tree?
> 
> I rebased it on current master.
> 
> The last patch with this seems dangerous (from reading the diff):
> 
> -git clean -dxf
> +if git clean -dxf
> +then
> +       rm -rf .git
> 
> I'd just .git
> 
> On ubuntu 22.04 I get this error:
> 
> make[1]: Verzeichnis „/tmp/release/Ubuntu/liburing/liburing-2.2“ wird verlassen
> dh_testdir
> dh_testroot
> dh_install -a
> dh_install: warning: Compatibility levels before 10 are deprecated (level 9 in use)
> dh_install: warning: Cannot find (any matches for) "lib/*/lib*.so.*" (tried in ., debian/tmp)
> 
> dh_install: warning: liburing2 missing files: lib/*/lib*.so.*
> dh_install: warning: Cannot find (any matches for) "usr/include" (tried in ., debian/tmp)
> 
> dh_install: warning: liburing-dev missing files: usr/include
> dh_install: warning: Cannot find (any matches for) "usr/lib/*/lib*.so" (tried in ., debian/tmp)
> 
> dh_install: warning: liburing-dev missing files: usr/lib/*/lib*.so
> dh_install: warning: Cannot find (any matches for) "usr/lib/*/lib*.a" (tried in ., debian/tmp)
> 
> dh_install: warning: liburing-dev missing files: usr/lib/*/lib*.a
> dh_install: error: missing files, aborting
> make: *** [debian/rules:74: binary-arch] Fehler 25
> dpkg-buildpackage: Fehler: Unterprozess debian/rules binary lieferte Exitstatus 2
> debuild: fatal error at line 1182:
> dpkg-buildpackage -us -uc -ui failed

I also found it changes the system path of the build host:

install -D -m 755 liburing.so.2.2 /lib/x86_64-linux-gnu/liburing.so.2.2
ln -sf liburing.so.2.2 /lib/x86_64-linux-gnu/liburing.so.2
ln -sf /lib/x86_64-linux-gnu/liburing.so.2.2 /usr/lib/x86_64-linux-gnu/liburing.so

This should use some $DESTDIR magic...

Maybe the DESTDIR handling is broken in general and the reason
why I got the above errors...

metze