public inbox for [email protected]
 help / color / mirror / Atom feed
From: Olivier Langlois <[email protected]>
To: Pavel Begunkov <[email protected]>,
	Jens Axboe <[email protected]>,
	Steven Rostedt <[email protected]>,
	Ingo Molnar <[email protected]>,
	[email protected], [email protected]
Subject: Re: [PATCH] io_uring: Add to traces the req pointer when available
Date: Tue, 25 May 2021 17:48:55 -0400	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On Tue, 2021-05-25 at 17:26 -0400, Olivier Langlois wrote:
> but the pointers should be hashed by trace.
> 
> That would be nice if someone more knowledgeable about the tracing
> system could jump in and comment about the hash-ptr option and tell
> when it is applied and when it is not...

My concern about hashing pointers directly in the io_uring code
directly. It is that by doing so will make it impossible for a
sufficiently priviledged user to get the raw pointer values without
reverting back the pointer hashing stuff.

that would not be the right way to address the security concern if the
tracing subsystem already hash them by default and is configurable to
display raw pointers if desired.

My issue is that I haven't been able to see hashed pointers output from
trace.

The only way that I know to get the traces is with 'sudo perf' and I
have never seen hashed pointers with it.

but the code is there... If you grep 'TRACE_ITER_HASH_PTR' in
kernel/trace/trace.c

I just haven't spent days in studying the tracing code to figure out
how it all works...



  reply	other threads:[~2021-05-25 21:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[email protected]>
2021-05-25  8:21 ` [PATCH] io_uring: Add to traces the req pointer when available Pavel Begunkov
2021-05-25  8:33   ` Pavel Begunkov
2021-05-25 21:26     ` Olivier Langlois
2021-05-25 21:48       ` Olivier Langlois [this message]
2021-05-25 22:28         ` Jens Axboe
2021-05-26  8:28           ` Olivier Langlois
2021-05-25 21:29   ` Olivier Langlois
2021-05-26 12:38   ` Stefan Metzmacher
2021-05-26 16:18     ` Olivier Langlois
2021-05-26 17:19       ` Olivier Langlois
2021-05-29 12:18         ` Pavel Begunkov
2021-05-28 22:42       ` Steven Rostedt
2021-05-29 12:30         ` Pavel Begunkov
2021-05-29 12:34           ` Pavel Begunkov
2021-05-29 17:55           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6133244fb6181420b27694abdfe3f42d43df8868.camel@trillion01.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox