From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH 3/6] io_uring/notif: move io_notif_flush() to net.c
Date: Tue, 4 Nov 2025 09:31:53 -0700 [thread overview]
Message-ID: <61d52217-a737-4222-85da-6d2ae15faba9@kernel.dk> (raw)
In-Reply-To: <7d071bfc-02c1-49b9-9c47-83ec62031530@gmail.com>
On 11/4/25 6:05 AM, Pavel Begunkov wrote:
> On 11/3/25 18:48, Jens Axboe wrote:
>> It's specific to the networking side, move it in there.
>
> It's there because notif.[c,h] know about struct io_notif_data
> internals and net.c in general shouldn't, otherwise it's not
> any more net specific than anything else notification related.
I guess the notif stuff is all networking anyway, almost doesn't
make sense to have it split out. But as long as we do, we can keep
that stuff in there. I'll drop this one.
--
Jens Axboe
next prev parent reply other threads:[~2025-11-04 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 18:47 [PATCHSET 0/6] Various minor cleanups Jens Axboe
2025-11-03 18:47 ` [PATCH 1/6] io_uring/slist: remove unused wq list splice helpers Jens Axboe
2025-11-03 18:47 ` [PATCH 2/6] io_uring/rsrc: use get/put_user() for integer copy Jens Axboe
2025-11-03 18:48 ` [PATCH 3/6] io_uring/notif: move io_notif_flush() to net.c Jens Axboe
2025-11-04 13:05 ` Pavel Begunkov
2025-11-04 16:31 ` Jens Axboe [this message]
2025-11-05 13:14 ` Pavel Begunkov
2025-11-03 18:48 ` [PATCH 4/6] io_uring/memmap: remove dead io_create_region_mmap_safe() declaration Jens Axboe
2025-11-03 18:48 ` [PATCH 5/6] io_uring/cancel: move request/task cancelation logic into cancel.c Jens Axboe
2025-11-03 18:48 ` [PATCH 6/6] io_uring/cancel: move __io_uring_cancel() " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61d52217-a737-4222-85da-6d2ae15faba9@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox