From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH] io_uring: increase max number of reg buffers
Date: Fri, 14 May 2021 08:51:10 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 5/14/21 8:42 AM, Jens Axboe wrote:
> On 5/14/21 5:06 AM, Pavel Begunkov wrote:
>> Since recent changes instead of storing a large array of struct
>> io_mapped_ubuf, we store pointers to them, that is 4 times slimmer and
>> we should not to so worry about restricting max number of registererd
>> buffer slots, increase the limit 4 times.
>
> Is this going to fall within the max kmalloc size?
Ah yes, it's just a u64 now, so should be fine. Might be worth considering
using vmalloc() for this in any case in the future, to make the allocation
more reliable. 128K of contig memory can sometimes be an issue in prod.
--
Jens Axboe
next prev parent reply other threads:[~2021-05-14 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 11:06 [PATCH] io_uring: increase max number of reg buffers Pavel Begunkov
2021-05-14 14:42 ` Jens Axboe
2021-05-14 14:51 ` Jens Axboe [this message]
2021-05-14 14:51 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox