Re: [PATCH liburing v2 3/4] bind-listen.t: Add tests for getsockname

[Jens Axboe <axboe@kernel.dk>]

On 11/25/25 2:27 PM, Gabriel Krisman Bertazi wrote:
> @@ -192,6 +192,30 @@ static int test_good_server(unsigned int ring_flags)
>  	}
>  	io_uring_cqe_seen(&ring, cqe);
>  
> +	/* Test that getsockname on the peer (getpeername) yields a
> +         * sane result.
> +	 */

Please use:

/*
 * xxx
 */

for multi-line comments.

> +	sqe = io_uring_get_sqe(&ring);
> +	saddr_len = sizeof(saddr);
> +	port = saddr.sin_port;
> +	io_uring_prep_cmd_getsockname(sqe, CLI_INDEX, (struct sockaddr*)&saddr,
> +				      &saddr_len, 1);
> +	sqe->flags |= IOSQE_FIXED_FILE;
> +	io_uring_submit(&ring);
> +	io_uring_wait_cqe(&ring, &cqe);
> +	if (cqe->res < 0) {
> +		fprintf(stderr, "getsockname client failed. %d\n", cqe->res);
> +		return T_EXIT_FAIL;

This will also fail on older kernels, where it should just return
T_EXIT_SKIP and the main "call these tests" part of main() should handle
that.

Any liburing test should run on any kernel. This is important as
regression tests are in there too, it's not just feature tests. I should
be able to run this on eg 5.10-stable and not get spurious errors and
then need to look at why that happened.

> @@ -417,5 +512,10 @@ int main(int argc, char *argv[])
>  		return T_EXIT_FAIL;
>  	}
>  
> +	ret = test_bad_sockname();
> +	if (ret) {
> +		fprintf(stderr, "bad sockname failed\n");
> +		return T_EXIT_FAIL;
> +	}
>  	return T_EXIT_PASS;
>  }

So here you'd just do:

	if (ret == T_EXIT_FAIL) {
		...
	}

	return T_EXIT_PASS;

so the test only fails if the test explicitly failed, which it should
not if getsockname isn't available on the running kernel.

-- 
Jens Axboe