From: Jens Axboe <[email protected]>
To: [email protected], [email protected]
Cc: [email protected], [email protected],
Xinghui Li <[email protected]>,
kernel test robot <[email protected]>
Subject: Re: [PATCH v2] io_uring: fix two assignments in if conditions
Date: Wed, 2 Nov 2022 08:19:19 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 11/2/22 2:25 AM, [email protected] wrote:
> From: Xinghui Li <[email protected]>
>
> Fixs two error:
>
> "ERROR: do not use assignment in if condition
> 130: FILE: io_uring/net.c:130:
> + if (!(issue_flags & IO_URING_F_UNLOCKED) &&
>
> ERROR: do not use assignment in if condition
> 599: FILE: io_uring/poll.c:599:
> + } else if (!(issue_flags & IO_URING_F_UNLOCKED) &&"
> reported by checkpatch.pl in net.c and poll.c .
I'm not super excited about this patch as the previous one
wasn't even compiled? Did you test this one, compile and runtime?
--
Jens Axboe
next prev parent reply other threads:[~2022-11-02 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 8:25 [PATCH v2] io_uring: fix two assignments in if conditions korantwork
2022-11-02 14:19 ` Jens Axboe [this message]
2022-11-03 2:50 ` Xinghui Li
2022-11-05 15:29 ` Jens Axboe
2022-11-05 15:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox